Date: Thu, 22 Feb 2007 11:22:28 +0100
From: "Joerg Roedel" <joerg.roedel@amd.com>
To: "Dor Laor" <dor.laor@qumranet.com>
cc: "Avi Kivity" <avi@qumranet.com>, "Pavel Machek" <pavel@ucw.cz>,
       kvm-devel@lists.sourceforge.net, akpm@osdl.org,
       linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] [PATCH 10/13] KVM: Wire up hypercall handlers
 to a central arch-independent location
Message-ID: <20070222102228.GC12801@amd.com>
References: <45DD6CF0.3010509@qumranet.com>
 <64F9B87B6B770947A9F8391472E032160A91BAF3@ehost011-8.exch011.intermedia.net>
MIME-Version: 1.0
In-Reply-To: <64F9B87B6B770947A9F8391472E032160A91BAF3@ehost011-8.exch011.intermedia.net>
User-Agent: mutt-ng/devel-r804 (Linux)
Content-Type: text/plain;
 charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 783
Lines: 27

On Thu, Feb 22, 2007 at 02:17:54AM -0800, Dor Laor wrote:
> I have Ingo's network PV hypercalls to commit in my piplien.
> Till then we can just add the test hypercall:
> 	case __NR_hypercall_test:
> 		printk(KERN_DEBUG "%s __NR_hypercall_test\n",
> __FUNCTION__);
> 		ret = 0x5a5a;
> 		break;
> 	default:
> 		BUG();

Is it a good idea to call BUG() on an undefined hypercall? I assume its
better to inform the guest that is has issued an illegal call...

Joerg

-- 
Joerg Roedel
Operating System Research Center
AMD Saxony LLC & Co. KG


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/