Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 14:04:11 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, qwen@analogixsemi.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        mliu@analogixsemi.com, hsinyi@chromium.org, bliang@analogixsemi.com
Subject: Re: [PATCH v2] drm/bridge: anx7625: Fix not correct get property
 counts
Message-ID: <20220314060411.GA1456403@anxtwsw-Precision-3640-Tower>
References: <20220311103525.1431890-1-xji@analogixsemi.com>
 <Yis0KXVqZokrkoP7@ravnborg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yis0KXVqZokrkoP7@ravnborg.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+dBXQ3uRzmG+QYRdtpBdPeAoGWmelgqwe4twqZD8Yr56kmEIR46mD3TMp2T1?=
 =?us-ascii?Q?Slx7C7fvdKEFTccRZPXeR01olvWJQtU8fpn6iEfOqZXyPaZuwPFNGWKPVWtr?=
 =?us-ascii?Q?pk3rKbqlZhtIbUf3hKCD3rgEJnZz1kVoPqti1GSJQgyA+E2dcViRfNclXzvw?=
 =?us-ascii?Q?Y0ILnINYjQprBfIovwJg5v4YLnzqJY7sQirC7jejfp/VexKOLQyX/YUAZXIQ?=
 =?us-ascii?Q?B/55nqowFMMuS9CHaFrvCZxecjPTxqYJIkb4qHmQ2pZ/8UD6e5iDhEd/t7JB?=
 =?us-ascii?Q?2MtP+04SyCXsyrz5qPZq0hTsSzV3XNj4myfd4ESjxK6zNsJfKr+6XlFgs7fL?=
 =?us-ascii?Q?uw+0EA3/eF3RIeMWlpcnd48qARof0NxEnmwBmACStvU4A/ivdLm/wHIjpsx4?=
 =?us-ascii?Q?MkSXEhQwkVEDRwMZpMNAlBPPM3a4MndM2uKlj4zEQoQ+j8c9ogoR4IJ5dpsm?=
 =?us-ascii?Q?jyZj9xKg5sj8XBpvJ0q6VdO7tGL7LWvHmMPutXrJpADzOmXpjkBij6YekYNc?=
 =?us-ascii?Q?Nctudu8hrLll7tvojE0QRvpNGdA/dMZA5qMWkcgSE0ZRrz7WJXEz8pWiBjJA?=
 =?us-ascii?Q?PRyEzYcUMi0YOzEdQONrHdLUV4Vzlo2u2bvUl/By0+zG7MknFuaTRbup91oM?=
 =?us-ascii?Q?kFyGpnl/emVHuzxiMWhvCz+9/xDS8P7Px3uHVMBBrCFoCOtfSGN08gUEwqho?=
 =?us-ascii?Q?ZuZoUGNQixFvCWkdYB5pmxi7P3HtmH+YBzfloSt5rQMG28ZDEu98UvFxK8HF?=
 =?us-ascii?Q?vvvWkPhY15VYiSYoUaD1eXjQa1aP5DVPBb9AClUNk70f+E5OlhKYmB8omvHH?=
 =?us-ascii?Q?HCLkDZxivAZhnXCXj6IC0LP+tkRiq6mXQfMEy3g3hTt9OY2uMyCpnupDBtFL?=
 =?us-ascii?Q?UKdA4d9taW6sekzOR4fM4w9GOK44+NZzQfUiSWqA0Ihhp0s5uRlq+vKQ4Ctn?=
 =?us-ascii?Q?tdCs+TgJRC6ygKL5wK3ornfIuD8obUK7o6L3ZN5Z097jIrZb5fgAHO1EupXX?=
 =?us-ascii?Q?hk7/nj9lJ+r3y9uHuhb6als2K2Zlky2Z1nT8OqrZsOrbkYhBjPwC406pKIyO?=
 =?us-ascii?Q?b6ytAbomtyQNru72wvP2VS2W1WKS385WMQdG/LV6gRLvwfhybjGErvllnYo0?=
 =?us-ascii?Q?9e9+J93A3h7FRJtSeNPEK6/y8LINB3BXAnAukpUMp29m7BbvdeX3ms8ihk2I?=
 =?us-ascii?Q?8MsSMsNUR4VoYVaK7Q0tknoye8OPjadi9AlcXHCeIYYBSiMKFVMbxJMFx6ce?=
 =?us-ascii?Q?aOZsXzOxJZpIxPLfRxlMvTktjfzUxCaEm5kiUfBSyhMQAnzoQU4SAPwC90/m?=
 =?us-ascii?Q?oYY2SzvF1cMFiee4tPmTyG3DixampCsKamCSnGiLRQhUyWdkr1eFjCn29rfQ?=
 =?us-ascii?Q?Xw3KTBeBenEJjc/+DCmfKUIcNTGQlzb1P1XbaqF8WTINGyG2rorOdbjyHtMZ?=
 =?us-ascii?Q?n61eHM5YZZrJcWFpzqfd8Km2VAgiHIrq?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: efa4340b-464d-43be-9e23-08da05807a38
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 06:04:19.3329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R4PZSTeDL5sOuUGUIGtJwMmJtzr8cXQBeOn+epnAOVrecMofrvaN8AH3oDpydipOmsn8wNCFmEeyUHmTo5ZJCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5651
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 11, 2022 at 12:36:09PM +0100, Sam Ravnborg wrote:
> Hi Xin.
> 
> On Fri, Mar 11, 2022 at 06:35:25PM +0800, Xin Ji wrote:
> > The property length which returns from "of_get_property", it means array
> > bytes count if the property has prefix as "/bits/ 8". The driver should
> > call function "of_property_read_u8_array" to get correct array value.
> > 
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > 
> > ---
> > V1 -> V2: Fix Sam comment, use of_property_read_u8_array to get array
> > value
> > ---
> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> >  drivers/gpu/drm/bridge/analogix/anx7625.h | 4 ++--
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index c6a9a02ed762..628cbf769141 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1598,8 +1598,8 @@ static int anx7625_get_swing_setting(struct device *dev,
> >  			num_regs = DP_TX_SWING_REG_CNT;
> >  
> >  		pdata->dp_lane0_swing_reg_cnt = num_regs;
> > -		of_property_read_u32_array(dev->of_node, "analogix,lane0-swing",
> > -					   pdata->lane0_reg_data, num_regs);
> > +		of_property_read_u8_array(dev->of_node, "analogix,lane0-swing",
> > +					  pdata->lane0_reg_data, num_regs);
> 
> The current implementation do a two step approach. First is find the
> number of elements and then read the elements.
> The number of elements is only used to limit what is read.
> 
> I suggest to use:
> 
> of_property_read_u8_array(dev->of_node, "analogix,lane0-swing",
> 			  pdata->lane0_reg_data, DP_TX_SWING_REG_CNT);
> 
> Then you a guaranteed to read at maximum DP_TX_SWING_REG_CNT entries.
> And as the number of elements is not stored anywhere that should be fine.
> 
> This looks simpler and matches what we for example do in
> drivers/gpu/drm/arm/malidp_drv.c - the only user in gpu/ of
> of_property_read_u8_array().
Hi Sam, the property is variable, so need two steps to approach, first
to get the property length, then to read the elements (the property
length may between 1 to DP_TX_SWING_REG_CNT). If directly to read the
element, I cannot exactly know how many registers need by configred.

Thanks,
Xin
> 
> 
> 	Sam