From: Duncan Sands <duncan.sands@math.u-psud.fr>
To: Simon Arlott <254ad70138dc1cdf241hjzcr0007jhhw@thunder.lp0.eu>
Subject: Re: [PATCH 2/2] usbatm: Detect usb device shutdown and ignore failed urbs.
Date: Thu, 22 Feb 2007 11:43:38 +0100
User-Agent: KMail/1.9.6
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <45DCBC26.1050308@simon.arlott.org.uk>
In-Reply-To: <45DCBC26.1050308@simon.arlott.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200702221143.38809.duncan.sands@math.u-psud.fr>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 731
Lines: 22

> +		/* the module/device has probably been removed */
> +		if (urb->status == -ESHUTDOWN)
> +			return;
> +
>  		if (printk_ratelimit())
>  			atm_warn(channel->usbatm, "%s: urb 0x%p failed (%d)!\n",
>  				__func__, urb, urb->status);

I would rather just suppress the warning in this case, and still do the delayed
schedule of the tasklet, in case this error was spurious and we're not really
about to be disconnected.

Ciao,

Duncan.

PS: I plan to work on the drivers this weekend.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/