Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Mar 2022 21:21:58 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
        robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, alistair@alistair23.me,
        samuel@sholland.org, josua.mayer@jm0.eu,
        letux-kernel@openphoenux.org
Subject: Re: [RFC PATCH 4/6] drm: mxc-epdc: Add update management
Message-ID: <Yi0A5inJh0Whkh5n@latitude>
References: <20220206080016.796556-1-andreas@kemnade.info>
 <20220206080016.796556-5-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="KGiIJO+uT5QL2O/C"
Content-Disposition: inline
In-Reply-To: <20220206080016.796556-5-andreas@kemnade.info>
Precedence: bulk


--KGiIJO+uT5QL2O/C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 06, 2022 at 09:00:14AM +0100, Andreas Kemnade wrote:
> The EPDC can process some dirty rectangles at a time, pick them up and
> forward them to the controller. Only processes not involving PXP are
> supported at the moment. Due to that and to work with more waveforms,
> there is some masking/shifting done. It was tested with the factory
> waveforms of Kobo Clara HD, Tolino Shine 3, and Tolino Shine 2HD.
> Also the waveform called epdc_E060SCM.fw from NXP BSP works with the
> i.MX6SL devices.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

[...]
> +	adj_update_region =3D upd_data_list->update_desc->upd_data.update_regio=
n;
> +	/*
> +	 * Is the working buffer idle?
> +	 * If the working buffer is busy, we must wait for the resource
> +	 * to become free. The IST will signal this event.

What does IST mean?


> +void mxc_epdc_draw_mode0(struct mxc_epdc *priv)

What does mode 0 imply? An overview of the possible modes would be
appreciated.

> +{
> +	u32 *upd_buf_ptr;
> +	int i;
> +	u32 xres, yres;
> +
> +	upd_buf_ptr =3D (u32 *)priv->epdc_mem_virt;
> +
> +	epdc_working_buf_intr(priv, true);
> +	epdc_lut_complete_intr(priv, 0, true);
> +
> +	/* Use unrotated (native) width/height */
> +	xres =3D priv->epdc_mem_width;
> +	yres =3D priv->epdc_mem_height;
> +
> +	/* Program EPDC update to process buffer */
> +	epdc_set_update_area(priv, priv->epdc_mem_phys, 0, 0, xres, yres, 0);
> +	epdc_submit_update(priv, 0, priv->wv_modes.mode_init, UPDATE_MODE_FULL,
> +		false, true, 0xFF);
> +
> +	dev_dbg(priv->drm.dev, "Mode0 update - Waiting for LUT to complete...\n=
");
> +
> +	/* Will timeout after ~4-5 seconds */
> +
> +	for (i =3D 0; i < 40; i++) {
> +		if (!epdc_is_lut_active(priv, 0)) {
> +			dev_dbg(priv->drm.dev, "Mode0 init complete\n");
> +			return;
> +		}
> +		msleep(100);
> +	}
> +
> +	dev_err(priv->drm.dev, "Mode0 init failed!\n");
> +}

> +#define WAVEFORM_MODE_GLR16			4
> +#define WAVEFORM_MODE_GLD16			5
> +#define WAVEFORM_MODE_AUTO			257

(How) are these mode numbers related to "mode 0"?


Jonathan

--KGiIJO+uT5QL2O/C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmItAOYACgkQCDBEmo7z
X9t/Fw//WJXYK5In6OQvEJeTImkCzhxbqniGCtE1+Jw/e2CfJQhBvZ77tElUhbHk
7IMr9JVLrQ19o32h7p/xFdeM6PWNVOiYFP7woHiU3SXasNB8t6JHxnUkX7CXhZvL
0FmfHtJRVGljFKi9VDMkicJxBwxsOQoEbAmfUiRdcimwjjDjKLl4HThP1kPaeMBm
6NEKVqBp5KoTqHmB+1XLfM9dZGwxrzHs5QYlAnyZZzv/OuZUgSjzhB2qK45nr8UH
1C7Psmeo7MaYP+ZqgqeYU3k9PcrQ9OxUUZ9HKjdPJ61oXhuTR0wesGpPulOxPbV/
uloHVV8bdYyVYrr/CAs3bhL5GvhcTkuTGO9y3OUW74l9xRsn8xQxwio6NbvSigdn
6AfjUk9F298wN7d3j7scryZ8RuDFkuocWSm0NdUhynQb2LeRXwYNz35KDq34DSgQ
SmR99dsdQJnqPre7oz7NQr6mPw3lretW5Rbfai60Wp5POwvLLXktZX4tVnkM0CBz
g0wZoXJywqgoRMcd1jRSUzcZMytfBss1dz7j3Fg3PNk7EylJ+/xWv72ZUOTMftXW
6hvwHRyo9SUpNi0sCWT1uh6aPAgrt2xQkTBObb9UJozSfL6mSxIChRbuSHKeLz4q
reX0HS0EEgsFYoVROEVMNxqS3kKg78ceqbE4Q6bnWZ2dpNHya0E=
=SlcQ
-----END PGP SIGNATURE-----

--KGiIJO+uT5QL2O/C--