Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3038467pxp; Mon, 14 Mar 2022 09:35:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjplU6ukFTwB3NZ7h+JhbzjDaillUO2TD7JthlaZjG+4Fm5nRjyGZlOtXMvjtGcObOnxNP X-Received: by 2002:a17:902:cec6:b0:151:e4a6:6af1 with SMTP id d6-20020a170902cec600b00151e4a66af1mr23713103plg.64.1647275732998; Mon, 14 Mar 2022 09:35:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647275732; cv=none; d=google.com; s=arc-20160816; b=s+zB5hMXZbLHtlIgkyUHx2JnMqIxQ7ES9Rjty1LbCVjfvnk2jFhlqAb3mepTt+1xXc hMRFIAlDayeartz+RtAOLmI8iSga0aKWwSHCJtUFqXrllgMeK/zsTyYfu3URDeD7JJ95 yOHgVcLqX44IFjGbckPGFKu6JBKJVbkJuq/HnV9ybTjWj4XcARuA8f2azJ0kGmXqnZri oYstV6g3BLSFaMYRAS3qahxgSQmUYi4+jG0Eu9x0UDCQ+qXtui/h8AK73dkbwTmwODZw m7JcZrbdZIfK5ilfCo+eBM7WAxudH+Kk1cK9Bpkui3I4dPg4wBGQOsROucFpwTz7iOx0 y6CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MyzLgXWTC26TKXIoZvgMJ2tAHcE3KCr9I9pKEI3g8ks=; b=wKDQGlcS7RghRWhrBVoZVGGl/I5NJF2OTPCPBUtOuhwAFShCkfhb8vXZImOekAHba8 ctZn8kvvfiv6KyvaZoOhZArHWUpRoiSND5SRcYdlbHv5RhCxtz2O8DzXi/44AZQpU8MR CpB9E1f9bbCyOR8mLVcUViN3Gu1jtNz6A6+4wfr5F+2Yr/hIw5I1oZsBn7ufNGLyp6LL Is+Vs62jJyGRVLMLMmqUZzvsVSQ/jc8CXSoqvhIBGwMGrrEZx46TcUadrCuiWmaciTdF S2/Zydhdou9uuFizC79HeHgHOFIHVN2WMKJiEnykeU2IVrtoPE6OPxWBNrm3Y27/Tdau cFiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z16-20020a170903019000b00151dd329250si17153542plg.598.2022.03.14.09.35.19; Mon, 14 Mar 2022 09:35:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbiCNB1r (ORCPT + 99 others); Sun, 13 Mar 2022 21:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiCNB1o (ORCPT ); Sun, 13 Mar 2022 21:27:44 -0400 Received: from cstnet.cn (smtp23.cstnet.cn [159.226.251.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 56CA21B790; Sun, 13 Mar 2022 18:26:33 -0700 (PDT) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-03 (Coremail) with SMTP id rQCowADX2MDFmS5iaUC+Ag--.30161S2; Mon, 14 Mar 2022 09:26:30 +0800 (CST) From: Jiasheng Jiang To: kuba@kernel.org Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: Re: [PATCH] atm: eni: Add check for dma_map_single Date: Mon, 14 Mar 2022 09:26:27 +0800 Message-Id: <20220314012627.2339943-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowADX2MDFmS5iaUC+Ag--.30161S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUU5i7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87 Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v 4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VUbrMaUUUUU U== X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Mar 2022 15:04:38 +0800 Jakub Kicinski wrote: >> + if (dma_mapping_error(&eni_dev->pci_dev->dev, paddr)) >> + return enq_jam; > > Probably better to drop the packet if mapping fails. Thanks, I will submit a v2 changing to "enq_jam". Jiang