Message-ID: <45DD8B83.5040604@chelsio.com>
Date: Thu, 22 Feb 2007 04:24:35 -0800
From: Divy Le Ray <divy@chelsio.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20061206)
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: shemminger@osdl.org, benh@kernel.crashing.org, netdev@vger.kernel.org,
       ebs@ebshome.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC] split NAPI from network device.
References: <20061213113537.6baf410f@dxpl.pdx.osdl.net>	<1166042552.11914.188.camel@localhost.localdomain>	<20061213154635.1f284bf6@dxpl.pdx.osdl.net> <20070220.213125.74747066.davem@davemloft.net>
In-Reply-To: <20070220.213125.74747066.davem@davemloft.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 26

Hi Dave,
>
> @@ -919,10 +920,7 @@ int dev_close(struct net_device *dev)
>  	 * engine, but this requires more changes in devices. */
>  
>  	smp_mb__after_clear_bit(); /* Commit netif_running(). */
> -	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> -		/* No hurry. */
> -		msleep(1);
> -	}
> +	netif_poll_disable(dev);
When dev_close() exits, NAPI_STATE_SCHED will be set,
whereas __LINK_STATE_RX_SCHED was previously reset.
The cxgb3 driver assumes that the device is not scheduled after the 
interface was brought up.
It's no longer true if the interface is brought up, brought down, and 
then brought up.
Should cxgb3 explicitly call napi_enable() on the open() path ?

Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/