Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3080907pxp; Mon, 14 Mar 2022 10:24:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSnCSF4XBqabzK+aMchqZjf0qDE8YVSE9ZEpxtcKJDGhv6TKHoFJeFJyItXlRl/npk7/RD X-Received: by 2002:a05:6a00:174f:b0:4f3:fe06:61b5 with SMTP id j15-20020a056a00174f00b004f3fe0661b5mr24893177pfc.50.1647278643213; Mon, 14 Mar 2022 10:24:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647278643; cv=none; d=google.com; s=arc-20160816; b=jH4lNiB2KwGCWcTv/CHXyUnBGFqmu2RnlbrAGi1/QpQyoyxwVPHNeW7buhhpRnhp8G mUHFXd9Zj0KT0Dmrm3hr3uChC10SNnLiYVI2YOp1f1UzmVeXMuFDSWdpXp2hPiL5o2F2 EzE2grvDa7TBd4Bz6GUIETilHSlwEaW47OjP+Dwdq2IDNDkJrCsnPH2uqvR7xRnP6L97 tQqZTF5e/HmQJRTqeLiNRcF3a5yPdFl7e2xyVxlh768Z/NvHJmnIT7LPDO45wCRQGfBM gOpZ3dnFU6Ac4SyjSFwiz2qP51/slAYTdG/NWGDx1zwWUC7mv6Ozhvmpkerm7bhvtPY8 hMmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=l+FDJNMmjM18bVB6RwO9FplJHFNfyzuMqvdkL3JfHOs=; b=WRo4z3V4WYbZMLiR9LmuGYJ92niBI1EhKt7CqBqX2F00muupDGUZ9BCclxc5uQyJcN u1DV9AimOfa+NCPPEtikJq5SBk2lut49t5ckEfE7oV4IwUNNwrwGcV6lDOSXCu2XMJTR IHDDODFbtNDQ4dAp7vK5DQhyiO3MgtMCNnfb0tI535cRSH1MReWRzMmGKb+pPbVcS6uX IlMmZbBzVidK2T+cPAERWEGX6Xn8FDPLBWZqT7IwzrhZ3kd8XO1A//EJQddJgd5aDcuW OqpKjs/POLnggqWOmkpdN9Pj/3M0okjEp/v9PM3akaframhdGQ9e6WgQo7hx0lT8g43r GS3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ncwhCcZZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h37-20020a632125000000b00378dd8db044si17665395pgh.631.2022.03.14.10.23.48; Mon, 14 Mar 2022 10:24:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ncwhCcZZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239812AbiCNL5h (ORCPT + 99 others); Mon, 14 Mar 2022 07:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239918AbiCNL5W (ORCPT ); Mon, 14 Mar 2022 07:57:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6474BC28; Mon, 14 Mar 2022 04:56:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 656BE60F6F; Mon, 14 Mar 2022 11:56:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C11BEC340E9; Mon, 14 Mar 2022 11:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647258959; bh=ckEwlbPoLs/EWoxMcONCSQf2ufdtZ85Xa9YK8WuVaHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncwhCcZZKSPWwKQPNXAvPJzpEPJi1rPDaPdaxACYcJBE6YRHXesAzbSqV+/xaTVWo CliDZNjXkRJu7GDuNn+JJQT3xQHMdSgw6zy3I3Y5SrgNHYqJ6dp/s76Y1pudoW+zDX pz5zKxwLWdTlc6E0p2NimmmB7CiNKyZAOItdIrTE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Jesse Brandeburg , Claudiu Manoil , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 17/43] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info Date: Mon, 14 Mar 2022 12:53:28 +0100 Message-Id: <20220314112734.902950656@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112734.415677317@linuxfoundation.org> References: <20220314112734.415677317@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 2ac5b58e645c66932438bb021cb5b52097ce70b0 ] The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata") Signed-off-by: Miaoqian Lin Reviewed-by: Jesse Brandeburg Reviewed-by: Claudiu Manoil Link: https://lore.kernel.org/r/20220310015313.14938-1-linmq006@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 3c8e4e2efc07..01a7255e86c9 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1489,6 +1489,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp"); if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); } -- 2.34.1