Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7ff5e217-4042-764b-3d32-49314f00ff54@intel.com>
Date:   Mon, 14 Mar 2022 08:32:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.7.0
Subject: Re: [PATCH V2 16/32] x86/sgx: Support restricting of enclave page
 permissions
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        "Dhanraj, Vijay" <vijay.dhanraj@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "bp@alien8.de" <bp@alien8.de>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Huang, Kai" <kai.huang@intel.com>,
        "Zhang, Cathy" <cathy.zhang@intel.com>,
        "Xing, Cedric" <cedric.xing@intel.com>,
        "Huang, Haitao" <haitao.huang@intel.com>,
        "Shanahan, Mark" <mark.shanahan@intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <4ce06608b5351f65f4e6bc6fc87c88a71215a2e7.1644274683.git.reinette.chatre@intel.com>
 <YhLhoMFPyOFZ2fsX@iki.fi>
 <DM8PR11MB55917F499CDF4CC7D426B0A7F63C9@DM8PR11MB5591.namprd11.prod.outlook.com>
 <YimWaAqEnXHbLdjh@iki.fi> <op.1itu5vkewjvjmi@hhuan26-mobl1.mshome.net>
 <Yis8LV99mORcLYs6@iki.fi> <Yis9rA8uC/0bmWCF@iki.fi>
 <97565fed-dc67-bab1-28d4-c40201c9f055@intel.com> <YiuQx+X9UQ2l22un@iki.fi>
 <e1c04077-0165-c5ec-53be-7fd732965e80@intel.com> <Yi65sM+yCvZU0/am@iki.fi>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Yi65sM+yCvZU0/am@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWFaQmx5bC8rZVdyRDQvUmVkWFZUa1l3clFuN3hXQTF3TkFsMXYzbnE4N081?=
 =?utf-8?B?TTVjTjh3dTJQSHJ4R0pWV2FRdmZBT1BoKzhWODNYV1g2dUpORHlGQWNlSmZF?=
 =?utf-8?B?cTFTdUVWRUM1OGljdVZDZUMrQ204cnlxR1JIZU5CdHUwY3gwMkVrWjFPYzk2?=
 =?utf-8?B?QmJkaXUzK0Z0TEcxSGt3ZEtKOGp6RVRzWkY4NHoxOHFHT1BZQWtkV1ZxWnc3?=
 =?utf-8?B?ZFpsaDdLSEg2aGl4MkRraE9kbWZtd0dDV3JiRjF3UnEzeER2TGZzSTJOMkFH?=
 =?utf-8?B?bDhZdWFzOUFGUXdIa2pteXlQYnB5Z3YyYzFXNkZSUEJ5K3NjMnJOa2g4bEsv?=
 =?utf-8?B?TzA2OEtsZ0hkb0tZNXVCTlhtb05BTDBVK3V0YUxJSWlOVzZsMGpLSHRYWnQr?=
 =?utf-8?B?VUZhdWlsdkRrUEZtazVCMitGQnJEaUtPM3BtbVpUczlKSFpGRzJoTThwTm83?=
 =?utf-8?B?eUJ4R05JM1VhZmVESS9hQnVwaWN3ZGRzcFZYMDloYWR2aEtvRmhOMCtJM2d2?=
 =?utf-8?B?YlNvNlFLbWQ0Yjh4eDE0S1dobmhaWFdqalFqTWk4cFlCMXFQazRiTmpwRHVJ?=
 =?utf-8?B?U25ieTBnd2IwRUxOQXNHYVVMaFFkUExmRzQ1NklzNWlzTU03ZTRPSDBCWjdF?=
 =?utf-8?B?cEp2aFVYYUFlUVR4VTZrS1VEUjVDbXpSaDBQWHNSMnYzcWU0K1NvN1dSTDkz?=
 =?utf-8?B?NEZJK0R5aVNEcUE2RWVqYU45ZHZXQXdrekoxRWRKUGpCRjhsWmxoZ1ZVTU53?=
 =?utf-8?B?eHZiSXFuOWt6dDJmbHNJTjhEYTJ6aU45OFVCalVTUS9WbnRIOHZLT3dCZjk4?=
 =?utf-8?B?d1R6MEtiSk5wTm9OYUU4QndzV3dRUjY5QmNQZnJBYTJ0THFqZzlSVTA3clY3?=
 =?utf-8?B?cmZvbGVqaHdLcTEvbGo0QnlKNUhKVm1jVE51clRLYnUxTFlaTVNmMFNFVWI5?=
 =?utf-8?B?MFRPc0NpYWJNT3NON3dSTEpYTXQ3M0RZSzRXMjFoZmYydWd4WjJMbXJBM3FR?=
 =?utf-8?B?aFE0VnZNNEplSWVSMzNaWEVnRzhmbDRpWTR3YVVlZkVVMkRpaVN5WkVlc1M4?=
 =?utf-8?B?Q1ZpYWg0ZFVHY21HRDI0b1VhZVU0b3c3aVZMS3NzMTFNUnIyREFIUHFqTlhS?=
 =?utf-8?B?YXNmTCtncEVXZ1RYWTlJY1FoVWlSd3pIanFPdmlaeWpSbGFXa3VOQjVzb0ow?=
 =?utf-8?B?eitzMmdDU1RNWk1SRGxYdmxsVllCMkJpZ0hHM2J6SHU2clZJNDBMSnM2REx0?=
 =?utf-8?B?KzRKdC85UndYUnl4OEVldTZBa0dFN2ZMVmdvMHZ1VFI0UDhHK1FkUUVPZGpX?=
 =?utf-8?B?anF4bmlHK0llbEJ0VklGT01sYklZVXNGbEw2M2FDVGVsVkl4YzZtcG5EWmVa?=
 =?utf-8?B?NHVINHAxdTAxOVVjeU5OQXd2Zk16NUZObXZzSmJNU0w5QVlESnJMLzJ0WTVy?=
 =?utf-8?B?dHE4czZWNFRwZk9YWk9RWUNNL2JNQ0tVMjI5dFJvRnpTV1NmSUNqNWE5NkFm?=
 =?utf-8?B?VXd1ZERMWTZMNmtPRExxY2lOS0pJbnFwNGZtQk1GWFNDZFBaREx6WDNvbGFk?=
 =?utf-8?B?SjJKQXdTaUpOTHMyT2hpR2VDa0FZTGJ1bW9vZkZPVk1MYXBwWjB3eUpoZmM1?=
 =?utf-8?B?b295NEo1dFo1dGRkZ2crNVdUekVmZmhsN3dxN2QvOHN5dCtmQnBqQ3lNTUh3?=
 =?utf-8?B?eUUvQnJFMkQzYjNmdXlqeWZmVlRsWnpBK3pWRENSS21GUDl0STh2ZjJ4dy82?=
 =?utf-8?B?Tk1XaWNUTmZ0Y0VUc2k0cWpEL3ZBKzBEenI3OGVxQ2R2L0FjRExrUVpUWENq?=
 =?utf-8?B?ODY4U1lQVXVpQzcxaVZJeXlSRmVLcFJQQXVIa3ozdHRCdmJTNEt4UGIvUXhh?=
 =?utf-8?B?YlNVS2lnc3hUR1ViM3ljU0E3TGU3cFVIYTJnajliZW8zMHdyNjU2UGFhWVdR?=
 =?utf-8?B?bm9tSFdlbkpLYk12dy9LeDRMSVE0b0JTMHJlVDF4S2gzSVIyeGROOHpjUTNn?=
 =?utf-8?B?UXBUL2NRRjRnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1257725-6965-44d3-bb3b-08da05cfdc79
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 15:32:34.4961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EV+GDabGbgxqekqHgI2OGNOQgYMnIzE54EjlCvSkNQ8TZwPHJXeiuNzz3ukqExDoqSNfx2w0uWYPTPxw+bRavgwHUCX3CZU3BZVQfR0z0tY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5335
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 3/13/2022 8:42 PM, Jarkko Sakkinen wrote:
> On Fri, Mar 11, 2022 at 11:28:27AM -0800, Reinette Chatre wrote:
>> Supporting permission restriction in an ioctl() enables the runtime to manage
>> the enclave memory without needing to map it.
> 
> Which is opposite what you do in EAUG. You can also augment pages without
> needing the map them. Sure you get that capability, but it is quite useless
> in practice.
> 
>> I have considered the idea of supporting the permission restriction with
>> mprotect() but as you can see in this response I did not find it to be
>> practical.
> 
> Where is it practical? What is your application? How is it practical to
> delegate the concurrency management of a split mprotect() to user space?
> How do we get rid off a useless up-call to the host?
> 

The email you responded to contained many obstacles against using mprotect()
but you chose to ignore them and snipped them all from your response. Could
you please address the issues instead of dismissing them? 

Reinette