Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 14:34:07 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Joe Perches <joe@perches.com>
Cc:     Julia Lawall <Julia.Lawall@inria.fr>,
        James Smart <james.smart@broadcom.com>,
        kernel-janitors@vger.kernel.org,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Subject: Re: [PATCH 4/6] scsi: lpfc: use kzalloc
Message-ID: <20220314113407.GM3293@kadam>
References: <20220312102705.71413-1-Julia.Lawall@inria.fr>
 <20220312102705.71413-5-Julia.Lawall@inria.fr>
 <846e22e76ba9e4c620df159b073bbf4e058a35f0.camel@perches.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <846e22e76ba9e4c620df159b073bbf4e058a35f0.camel@perches.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IDwno1G6P1bYLM3lo9mq+xo42OvrRMNgwJUDpqk6ioEQsEns2V7STfX0vy5s?=
 =?us-ascii?Q?Xcei1T2G3SrP7+ABwHnR2X5j5L99zIy5Lt7Ht31QBV2D0ahdUxiGjs0Z34aF?=
 =?us-ascii?Q?txV6vT5P0M0nzqX5neIJFIYBrTp2LfOyPfUhmju19KCWRgJTXqtG6ZkiLcGz?=
 =?us-ascii?Q?UJxMKXmMBDZszk/xMx6VoAt9DTwTI/ftVnh+8PUctbXf2GVZo5pFdhIOS4Am?=
 =?us-ascii?Q?l/CxgdrxpZ20Qx2s+rtND23sFZSO0P9YhZlGqROQ5a5nnyIZjxkP4tpGZg1i?=
 =?us-ascii?Q?8DFvZxys4ATa84lv5VBmC8VItTBu7VCakQ7YZ0+NVSQmu/tDqk7V3dQkPr6U?=
 =?us-ascii?Q?e2lHXrMJBnzu5nkelMpKO49R1Nfl5yTdoKTlPlBOH147P+PR6HvipVLNOW9S?=
 =?us-ascii?Q?KHguG3gaPW+ojqXDKr6m+rt7pCzeNF1G20ug+/pzQnaqBT8WI5JwORL4OEOd?=
 =?us-ascii?Q?Nrk9Shzkxcabzb7U9WP8ETpVgU/3K9F9ZQ8g2Q7HU1/8Dp/e80D/tA8mSH4b?=
 =?us-ascii?Q?y5ENZ4x/J9E2sASfGS5CgETLtJP6djeQsUuTcqNZibatzgbzqB/nTGhhsJNJ?=
 =?us-ascii?Q?LhVbLm69mC6h93xSJv5CVkx9IgpFKRS53jsP8zJ1+OC6Q2V30O0EAhbY32Xc?=
 =?us-ascii?Q?m5MS0u+Ot7kIWmzv4k3mPn7opL7exL/taVufWkDdHNYJmpH7mb9Bs74Q+Tbx?=
 =?us-ascii?Q?W3wytqa0eQ+gmBtBp26bk0ED14R/21a3VOQZQ7bM1IDOJCb68tx/WFyKFnRi?=
 =?us-ascii?Q?1Za3rjMjhRI7lw5w9B1MTAUv7UY1HEioqt76o2ummcWV/hsiYk8AuzGV5KOe?=
 =?us-ascii?Q?QWJ0gL3sj3ThdedYSk2251dvm4e4OHcT3ZdYCRZJXbWkLdrgNYy5cti1aZ2g?=
 =?us-ascii?Q?JZidhsLHknsGI/6UOKYE5kMtQpUNRfrZWIUxjFs9Qx+84lxjutTg9dj2pOmB?=
 =?us-ascii?Q?wkaSkT+fpU/tDpp8dGEbs5evmk+lf7O9uuqY3yY9IEVrVSMbgIZmJRZKApZN?=
 =?us-ascii?Q?28qbyzb20Q0GyYYfO2+2iH4qLTlVIitvISzV4Z37WywY6dR3GO7tMjRh3fjU?=
 =?us-ascii?Q?D9zyyjtnY6NU5Q4E3/gOQ9a2DT2fBhjiAAN6uga+bYsJAbLgqlEaaWYg+B+8?=
 =?us-ascii?Q?fCG2t9jgdd5jV7y87XYcialrhTIi9NWgeG+RMN3pgx12RQLVHsWgPt4SCFQy?=
 =?us-ascii?Q?tS0m/1Jf4Mo8LdjQng+cx+WW9pc6gw+QYEBKtcYEiEywK2fd/V7L+guEDAcq?=
 =?us-ascii?Q?JtjlBS0Sva7NIXdiulwu7iMJJxTL3cE1/Zd6i96fw0aq/WRc2hyM7wtgMOlm?=
 =?us-ascii?Q?37MwFkyrunuBM4psaEJIZh0RO6899rkz8KSAkiszLfP+SPJOfUgpgepvRcjl?=
 =?us-ascii?Q?6BuzBiy/4SKM5sUBKu2V3Pqzb0QMEwdtDo7YdIzKFNj7bAy+8LciwWdydAc5?=
 =?us-ascii?Q?GZh0di/dYZ32d/W86Yyj7xGETGoMxyTbCfAqglZgIMU2DDEHuf06DA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3281e28a-5242-4851-4655-08da05ae9722
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2022 11:34:24.8619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hbv1/jkpS0vhkBrJlTRtVlFKiB/QatSpFTdrMnQz0wTfmo4ZdQKRT3P/ECBvIOJMEW30svkGjYdDSpOadDE6s/+giV1q6RTCNRgxCiw/j6E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4252
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10285 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=860
 bulkscore=0 mlxscore=0 phishscore=0 spamscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203140074
X-Proofpoint-GUID: q49q1LWumz7dsiLAgwC_wpHJBMOxrQ9A
X-Proofpoint-ORIG-GUID: q49q1LWumz7dsiLAgwC_wpHJBMOxrQ9A
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 12, 2022 at 01:45:01PM -0800, Joe Perches wrote:
> On Sat, 2022-03-12 at 11:27 +0100, Julia Lawall wrote:
> > Use kzalloc instead of kmalloc + memset.
> []
> > diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> []
> > @@ -6272,10 +6272,8 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
> >  				 phba->hba_debugfs_root,
> >  				 phba, &lpfc_debugfs_op_slow_ring_trc);
> >  		if (!phba->slow_ring_trc) {
> > -			phba->slow_ring_trc = kmalloc(
> > -				(sizeof(struct lpfc_debugfs_trc) *
> > -				lpfc_debugfs_max_slow_ring_trc),
> > -				GFP_KERNEL);
> > +			phba->slow_ring_trc = kzalloc((sizeof(struct lpfc_debugfs_trc) * lpfc_debugfs_max_slow_ring_trc),
> > +						      GFP_KERNEL);
> 
> kcalloc
> 

Did someone have a Coccinelle script that converted kzalloc() to
kcalloc()?

regards,
dan carpenter