Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3183898pxp; Mon, 14 Mar 2022 12:46:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPjvhdLVKoEMLfJGEn/ww9wPnjXXuzVopvEbwjm/OPqg8Bw29mnbMXi4o7j0zdUBrQFXao X-Received: by 2002:a63:854a:0:b0:380:352e:8009 with SMTP id u71-20020a63854a000000b00380352e8009mr21505079pgd.292.1647287197611; Mon, 14 Mar 2022 12:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647287197; cv=none; d=google.com; s=arc-20160816; b=uB3lZzyIUqik2J3BxuvFLTu3TBBX8jJQzqjsOfyT+0IBAbS5/4rinDnijdEQM1emT1 cYTtY25WR+1U9Q1m1A5weFLeJpVBB3q6mANbF4DUfvgZzkzWmixxTCG8RYuR1LJMbYlJ 9GxZ8NC0O+8F+53pA+83sjGl06UwCOezeZV+6xkfO4/yh4a1ivKb/YT7Z2NwSMbkKWdQ jCKvvndb/KO3QqeMa82kac5jt1nDNruoTTZDze50dIV3wHQdztyMcqHt+lrxIzSf9cbc bcvlBs+ap1xpRBJwYp8N+v0TDaUm0Qkzq8hJMfqFsEXUGoq0cCgBJHMPXcHHd8Xr6dbn uh4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DN5gzr1+MzCYNh9My4LEBDRtH0OSbo/Y1rpo0wkszJ8=; b=tnEv9I0KqDPX7n9hkjdapPOuCu6EvXdxz9v0K4vmBNtdRy5ZrUO6mAo+4jcunWNhBe JxJRg5kzWRs65JdtKsYKiLQn2h4GixRhKYyu8yHkrVsj2q/LkEj0v4M0mynn+1r6ulLX ViCAHrxifX2LO0MjcGYuhv4LzZRZeyQWiZ1us2pGpQ4zcD37qr/JasUCqGdOKeWrBWAr wnNEsgaChv5i4x+Uww2FkNQGB/jN4wIGSnQfWKx5cONVhc+0bzL5TB0FXNp6a8vdbvNf KTVRmHMIA+3l3tMFcYjGTQ1vlCuw9/ktBf/eKWccupwHWJqM/ZUAtdGGy06lw6jW+Ss0 U7vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R14hM1Ku; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u20-20020a056a00125400b004f7773c7487si13250413pfi.83.2022.03.14.12.46.23; Mon, 14 Mar 2022 12:46:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=R14hM1Ku; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243384AbiCNMaw (ORCPT + 99 others); Mon, 14 Mar 2022 08:30:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242779AbiCNMTk (ORCPT ); Mon, 14 Mar 2022 08:19:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 962925007D; Mon, 14 Mar 2022 05:14:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC14160B06; Mon, 14 Mar 2022 12:14:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC680C340EC; Mon, 14 Mar 2022 12:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647260073; bh=7RI4WjNoYbGJ2IO97UY2MisVPVgUVh3CGxFmBuI+nDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R14hM1KuCOjLVG5uG1wmf9V7ZISTBqfz1VuzM7GfVZOx/mbUlZ0xH0BCxhY8IGqZY 6+5x6HOoPjVZO/7FCvv1sJW1ieHZ06nZUQlx94LWJhJJcmY6yAJdWgNwoYvYa4AWRa jwQzC4HOu3ICIFCsf6+2u3UdIEEfgpPsBrs01kwc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Ben-Ishay , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.16 048/121] net/mlx5e: SHAMPO, reduce TIR indication Date: Mon, 14 Mar 2022 12:53:51 +0100 Message-Id: <20220314112745.468096325@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112744.120491875@linuxfoundation.org> References: <20220314112744.120491875@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Ben-Ishay [ Upstream commit 99a2b9be077ae3a5d97fbf5f7782e0f2e9812978 ] SHAMPO is an RQ / WQ feature, an indication was added to the TIR in the first place to enforce suitability between connected TIR and RQ, this enforcement does not exist in current the Firmware implementation and was redundant in the first place. Fixes: 83439f3c37aa ("net/mlx5e: Add HW-GRO offload") Signed-off-by: Ben Ben-Ishay Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/en/tir.c | 3 --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 +-- include/linux/mlx5/mlx5_ifc.h | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c index da169b816665..d4239e3b3c88 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tir.c @@ -88,9 +88,6 @@ void mlx5e_tir_builder_build_packet_merge(struct mlx5e_tir_builder *builder, (MLX5E_PARAMS_DEFAULT_LRO_WQE_SZ - rough_max_l2_l3_hdr_sz) >> 8); MLX5_SET(tirc, tirc, lro_timeout_period_usecs, pkt_merge_param->timeout); break; - case MLX5E_PACKET_MERGE_SHAMPO: - MLX5_SET(tirc, tirc, packet_merge_mask, MLX5_TIRC_PACKET_MERGE_MASK_SHAMPO); - break; default: break; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index d92b82cdfd4e..22de7327c5a8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3592,8 +3592,7 @@ static int set_feature_hw_gro(struct net_device *netdev, bool enable) goto out; } - err = mlx5e_safe_switch_params(priv, &new_params, - mlx5e_modify_tirs_packet_merge_ctx, NULL, reset); + err = mlx5e_safe_switch_params(priv, &new_params, NULL, NULL, reset); out: mutex_unlock(&priv->state_lock); return err; diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 58a60e46c319..66522bc56a0b 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -3410,7 +3410,6 @@ enum { enum { MLX5_TIRC_PACKET_MERGE_MASK_IPV4_LRO = BIT(0), MLX5_TIRC_PACKET_MERGE_MASK_IPV6_LRO = BIT(1), - MLX5_TIRC_PACKET_MERGE_MASK_SHAMPO = BIT(2), }; enum { -- 2.34.1