Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nicolas Saenz Julienne <nsaenzju@redhat.com>
To:     feng.tang@intel.com, tglx@linutronix.de
Cc:     andi.kleen@intel.com, bp@alien8.de, dave.hansen@intel.com,
        hpa@zytor.com, len.brown@intel.com, linux-kernel@vger.kernel.org,
        mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org,
        rui.zhang@intel.com, tim.c.chen@intel.com, x86@kernel.org,
        mtosatti@redhat.com, nsaenzju@redhat.com, frederic@kernel.org
Subject: Re: [PATCH v3 1/2] x86/tsc: add a timer to make sure tsc_adjust is always checked
Date:   Mon, 14 Mar 2022 18:52:07 +0100
Message-Id: <20220314175207.274870-1-nsaenzju@redhat.com>
In-Reply-To: <20211117023751.24190-1-feng.tang@intel.com>
References: <20211117023751.24190-1-feng.tang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Feng, Thomas,

> On Wed, Nov 17, 2021 at 10:37:51AM +0800, Feng Tang wrote:
> Normally the tsc_sync will get checked every time system enters idle state,
> but Thomas Gleixner mentioned there is still a caveat that a system won't
> enter idle [1], either because it's too busy or configured purposely to not
> enter idle. Setup a periodic timer (every 10 minitues) to make sure the
> check is always on.
> 
> [1]. https://lore.kernel.org/lkml/875z286xtk.fsf@nanos.tec.linutronix.de/
> Signed-off-by: Feng Tang <feng.tang@intel.com>

I can see this timer interrupting my system's nohz_full CPUs. It'd be nice to
be able to avoid the noise. A solution is using 'tsc=reliable', but IIUC this
is not what the flag was created for. Any ideas/suggestions?

Regards,
Nicolas