Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] md: remove unused dm_thin_remove_block()
From:   Zhiqiang Liu <liuzhiqiang26@huawei.com>
To:     <agk@redhat.com>, Mike Snitzer <snitzer@redhat.com>
CC:     <dm-devel@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linfeilong <linfeilong@huawei.com>,
        lixiaokeng <lixiaokeng@huawei.com>,
        wuguanghao <wuguanghao3@huawei.com>, <liuzhiqiang26@huawei.com>
References: <b0ec028e-bc9e-f705-9674-ffc4a01ee2f0@huawei.com>
Message-ID: <4b7e5e2c-a847-4e40-1f23-de71753fe9e8@huawei.com>
Date:   Mon, 14 Mar 2022 21:23:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <b0ec028e-bc9e-f705-9674-ffc4a01ee2f0@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

friendly ping..

On 2022/2/16 14:37, Zhiqiang Liu wrote:
> dm_thin_remove_block() is no longer unused, just remove it.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
>  drivers/md/dm-thin-metadata.c | 12 ------------
>  drivers/md/dm-thin-metadata.h |  1 -
>  2 files changed, 13 deletions(-)
>
> diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c
> index 1a96a07cbf44..986a2dc9a686 100644
> --- a/drivers/md/dm-thin-metadata.c
> +++ b/drivers/md/dm-thin-metadata.c
> @@ -1740,18 +1740,6 @@ static int __remove_range(struct dm_thin_device *td, dm_block_t begin, dm_block_
>  	return dm_btree_insert(&pmd->tl_info, pmd->root, keys, &value, &pmd->root);
>  }
>
> -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block)
> -{
> -	int r = -EINVAL;
> -
> -	pmd_write_lock(td->pmd);
> -	if (!td->pmd->fail_io)
> -		r = __remove(td, block);
> -	pmd_write_unlock(td->pmd);
> -
> -	return r;
> -}
> -
>  int dm_thin_remove_range(struct dm_thin_device *td,
>  			 dm_block_t begin, dm_block_t end)
>  {
> diff --git a/drivers/md/dm-thin-metadata.h b/drivers/md/dm-thin-metadata.h
> index 7ef56bd2a7e3..4d7a2caf21d9 100644
> --- a/drivers/md/dm-thin-metadata.h
> +++ b/drivers/md/dm-thin-metadata.h
> @@ -166,7 +166,6 @@ int dm_pool_alloc_data_block(struct dm_pool_metadata *pmd, dm_block_t *result);
>  int dm_thin_insert_block(struct dm_thin_device *td, dm_block_t block,
>  			 dm_block_t data_block);
>
> -int dm_thin_remove_block(struct dm_thin_device *td, dm_block_t block);
>  int dm_thin_remove_range(struct dm_thin_device *td,
>  			 dm_block_t begin, dm_block_t end);
>