Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3339473pxp; Mon, 14 Mar 2022 17:08:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYd+h/CP2bagRTgydVYoAFpj6ay0YAQT92tcOT502FIQLOujS59uMgowTXukGPdIb8blLK X-Received: by 2002:a63:7:0:b0:37f:fa5b:95f9 with SMTP id 7-20020a630007000000b0037ffa5b95f9mr22475911pga.57.1647302910080; Mon, 14 Mar 2022 17:08:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647302910; cv=none; d=google.com; s=arc-20160816; b=grWczwL1gnEgjHdMRhkux0h+0dweCK86IJlXm33q6UpRc0le3u6MYBIEDPHIMUgbAV FsxE/fy/KIDX3rIp0k+Gj/51nScMa23Wj/7k6ZwuoKrMkJEQIoHr1FoK7UMR1fhzKeVa k6WO9dMO1XX9yyYNpY2E8E8dH9PCoH+h6M9Wqg5f+pVMtp3oZYlQxgFDt/PbGqETgB1M ndy+x0jm6tYVtZgVHt7Q871q4i36nrHTIfGgL+e6Sm2ldXjVl/m3FQ6TN7CRUW/KFEIu y3ShMzaT0LHz4Fm0K8axSDBWgTKkbwddY9rxsUMhv8M+G2Bct/FuDCyRIPoH2319I8UR 72uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=/9oNZzs4fmNiMkxz1aiVwRO3iyHrlp6NUbtElgEZxtk=; b=TvuIFasgWe3HduMAT7JluKJHt7tCvs0L4ey5Qp247sCfdF6kiZtoVFhZvLGxVLFMJH 39vJhetu69cVMRxfFkU1gg/NdF63oER5PIUfKZgNyZWgIc8a5d0JIAJH5PGtdZsUB2CV BYMSm9NXfoXVjh2G+8Eb4Qk/qSMDvL9hpPf1Br1OzXUHl8EeZnOWP1sd0fqKNDr8ExbX v2O/KzEPYxMVchkS7AJ/qI9menUDukeY0KFgloHP6w3Ir8rOwFCIcgXGLLnoZ/vHuwaQ tFk/9NsbPFzMatUo2oGaAzI/rn2WRSCId/uVCPcxJE1CfKcKQz0Bhfh47q1LVrHHSpJA 181A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a170902e54b00b0015393b23d95si608617plf.2.2022.03.14.17.08.12; Mon, 14 Mar 2022 17:08:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240141AbiCNOya (ORCPT + 99 others); Mon, 14 Mar 2022 10:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233567AbiCNOyZ (ORCPT ); Mon, 14 Mar 2022 10:54:25 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 981FA255B3; Mon, 14 Mar 2022 07:53:14 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nTm4O-0006nG-02; Mon, 14 Mar 2022 15:53:12 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 6D6BDC2E31; Mon, 14 Mar 2022 15:52:34 +0100 (CET) Date: Mon, 14 Mar 2022 15:52:34 +0100 From: Thomas Bogendoerfer To: Miaoqian Lin Cc: Serge Semin , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: cdmm: Fix refcount leak in mips_cdmm_phys_base Message-ID: <20220314145234.GE13438@alpha.franken.de> References: <20220309091711.3850-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309091711.3850-1-linmq006@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_NONE,T_SCC_BODY_TEXT_LINE,T_SPF_HELO_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 09:17:10AM +0000, Miaoqian Lin wrote: > The of_find_compatible_node() function returns a node pointer with > refcount incremented, We should use of_node_put() on it when done > Add the missing of_node_put() to release the refcount. > > Fixes: 2121aa3e2312 ("mips: cdmm: Add mti,mips-cdmm dtb node support") > Signed-off-by: Miaoqian Lin > --- > drivers/bus/mips_cdmm.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]