Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3351369pxp; Mon, 14 Mar 2022 17:28:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKtRDPluYzcG8/U1fJWFPqO/jE10M9/dFLYKh86s2PgpjO2svPhEgG+UBYu1xI02D0B+IL X-Received: by 2002:a05:6402:2552:b0:416:a745:9626 with SMTP id l18-20020a056402255200b00416a7459626mr23328966edb.405.1647304083621; Mon, 14 Mar 2022 17:28:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647304083; cv=none; d=google.com; s=arc-20160816; b=TtblP4X/eZV/aWuJSxX6EY6V0ZfsCdJRPn2Gb7b6sejtZOnnNABde55tchS48MVb1M Q0rwBGD/8cjFND13xNls6+4ROQII0LPdEuhdFYrjso2vi77hN5NMvev0PZRPB6Xc+z+p vY4wjkJrl3wCmXgc4zpkkxqMCl2vtWzsKKoFUAsrr6shH9gXiSyE0/raBt+TUspmdL+9 Gj8foqUkYEjnNDKg+fFGDQt84kgRamnqeeIsU6RzgV9Cj1ZHBdUBoNNPcGg/z40GYj63 jJPW6LW5EIEK1y9CxULEtBufvltPgRQreAnFWrWtRVk5IPtG4FB5j5D6p09Ypn97RKER cKig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+BMB0tJXVLTSjn2TPQLTS+wSN7/waxpXa1hncq+3D/0=; b=V2t0in6aeVboirNUXGVPRJmxM1AaGkfl/LtMYNXleUdxU4asV+QQtkS+TmdBam987j bNjwnND/W4dz4ZVzvCXa3U5O60XGU/Tq/Fse3ZeMNJxcGG0Wt9eCVP1D3E8MTVdTCNo1 VH8c829OcVt3WqWM8ur48dAIhQZBgOXTDiwzG+IiBA035QpZhmsjZa2hoQzrGMffLc0T MsIvsW0HdtmfXDFO3dUrlFKSt7RY6GMpqLjob9ko+mu2ML9aMapk8lN5HkOeeNoYXLk0 iA6RYC/uGdzKUqcIZZPb1i15xNR3/DWSNW0aoc87RBaINfqhBtA+CzJ9UuvhpDz6ZegR q4gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hNRlma8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a1709070b0d00b006db5716c858si9597833ejl.63.2022.03.14.17.27.39; Mon, 14 Mar 2022 17:28:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hNRlma8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240272AbiCNMDe (ORCPT + 99 others); Mon, 14 Mar 2022 08:03:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240336AbiCNMCs (ORCPT ); Mon, 14 Mar 2022 08:02:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 944F548E7B; Mon, 14 Mar 2022 05:00:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6579C61260; Mon, 14 Mar 2022 12:00:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69FA4C340ED; Mon, 14 Mar 2022 12:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647259200; bh=HsN3ea+pGBixgNb6E6XkYeexSxxETtROPScpPCIEJhw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNRlma8HSQ4S7bvQqTVF1A3d8CV2XBPIX64Ir2Vuc3jQ2DyGeZwU5FnwARfNwnU34 SW0J0hNbKIf5jvfszucP9vR8Wunt9t7aAar4g9J5F1Ae6DBYzvvPC8H99fGZMOhvmj 26L7bogT6FHddQ08UX00NXZ90/P7+LZ+XZKFKD2U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiasheng Jiang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 25/71] net: ethernet: lpc_eth: Handle error for clk_enable Date: Mon, 14 Mar 2022 12:53:18 +0100 Message-Id: <20220314112738.637983827@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112737.929694832@linuxfoundation.org> References: <20220314112737.929694832@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiasheng Jiang [ Upstream commit 2169b79258c8be803d2595d6456b1e77129fe154 ] As the potential failure of the clk_enable(), it should be better to check it and return error if fails. Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") Signed-off-by: Jiasheng Jiang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/nxp/lpc_eth.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 9e098e40fb1c..a9a9bf2e065a 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -1468,6 +1468,7 @@ static int lpc_eth_drv_resume(struct platform_device *pdev) { struct net_device *ndev = platform_get_drvdata(pdev); struct netdata_local *pldat; + int ret; if (device_may_wakeup(&pdev->dev)) disable_irq_wake(ndev->irq); @@ -1477,7 +1478,9 @@ static int lpc_eth_drv_resume(struct platform_device *pdev) pldat = netdev_priv(ndev); /* Enable interface clock */ - clk_enable(pldat->clk); + ret = clk_enable(pldat->clk); + if (ret) + return ret; /* Reset and initialize */ __lpc_eth_reset(pldat); -- 2.34.1