Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3440785pxp; Mon, 14 Mar 2022 20:26:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVblLlspzeN725haqcXdvpXkNaEXp3Q+Sf0oSessSVHrlM5Pq3P/LLrd0NhTnAteZNTm6q X-Received: by 2002:a17:907:2d29:b0:6db:2b1f:333a with SMTP id gs41-20020a1709072d2900b006db2b1f333amr20982582ejc.704.1647314797860; Mon, 14 Mar 2022 20:26:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647314797; cv=none; d=google.com; s=arc-20160816; b=HVwZ5Sw6zpNwitdoCyRjUyQ8urAzwrTNpx25rOPlhX5ucI/9IH65YrvxF7RJqZoZjq uvYX6EN/0Ca72mBmg+U2lZkwQbJ/O/IGwHyiox1p1NDHr70uZJjGvS/zkQhv0CQFv6DT pRveCHt4QrjMDEKLITYGhExguE6IqeRU3QBvca/ZwyeleoQRwYuUMDU7SwkgNO3lMtWk u75LYye2S8IZZtjSQYrx7faURfv0dRECd04ChqJSsRQCu4t7HhKwpgbS/l88ob+6369h KL1HX7YKZnvp1DsxaKrbhnwkZdh55PAYokVFIH5PUnyZapxeJyQkpPnXFMm6x/YmAnUB UY7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DSUebwwEEjVWL0M8WMGDHrNjpYFuf9YXunDB24zTBYg=; b=AufMKmz8AimX+r77xO6vV0Gsc2ZDkLYEo1ADlFn1fI0gYjnnbxD6YkbGwbn223mhVq ZlnLT3OlCB3A3GJeHqGviSzg05565XLPAk/p5nNoOtwXCJ27E1QUKrEl+h99tqowLpjH lzx3o4B5VXTAdr3gHP/1tWivJiakb0O3nlq5y+obXfZod/cb45RpdRdDoF+1ISU0OxN0 6/UtGVBnIVyMrX0ikzO7Bixw9XIx8kf5FKYZwufrgGvvFv3umv2Y+CYRkNR5c8Yi4hrc D9a5YcMgDVzIJyjOnnVBz6GEbm7CmHOQDAiJ+NaWLMC03l+sUl2PgvxERLBP1+5ItmWn YhSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DL0kF02E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr32-20020a1709073fa000b006db381c37cesi13224904ejc.17.2022.03.14.20.26.13; Mon, 14 Mar 2022 20:26:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DL0kF02E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241027AbiCNMOV (ORCPT + 99 others); Mon, 14 Mar 2022 08:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242689AbiCNMKj (ORCPT ); Mon, 14 Mar 2022 08:10:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD6EE31531; Mon, 14 Mar 2022 05:09:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6FE416130D; Mon, 14 Mar 2022 12:09:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76DDFC340E9; Mon, 14 Mar 2022 12:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647259761; bh=U5Rul2AMCPlEOya2A6Nt5TwYosi8R9/tJibX+jcrzzg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DL0kF02EGZndGKMDMeHrdTLOXjI+zq0p+gXXJZOUZ00lgC1tfrd9cK3E+ZvQ5CeSz Z3x6ym6rWurZfSELJ4Qq1NDyY7sVRNY3kgKFxcD/0Re7csoHOC1PVzgZxEAwZEwefN 3JOOuCltbUDfC+jG0DN9kCO0s2jPSoDQGsXIgr/A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Leszek Kaliszczuk , Tony Nguyen , Sasha Levin Subject: [PATCH 5.15 032/110] ice: Dont use GFP_KERNEL in atomic context Date: Mon, 14 Mar 2022 12:53:34 +0100 Message-Id: <20220314112743.934364058@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112743.029192918@linuxfoundation.org> References: <20220314112743.029192918@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 3d97f1afd8d831e0c0dc1157418f94b8faa97b54 ] ice_misc_intr() is an irq handler. It should not sleep. Use GFP_ATOMIC instead of GFP_KERNEL when allocating some memory. Fixes: 348048e724a0 ("ice: Implement iidc operations") Signed-off-by: Christophe JAILLET Tested-by: Leszek Kaliszczuk Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index d6ee62ae4480..137a054dd1e3 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -2874,7 +2874,7 @@ static irqreturn_t ice_misc_intr(int __always_unused irq, void *data) struct iidc_event *event; ena_mask &= ~ICE_AUX_CRIT_ERR; - event = kzalloc(sizeof(*event), GFP_KERNEL); + event = kzalloc(sizeof(*event), GFP_ATOMIC); if (event) { set_bit(IIDC_EVENT_CRIT_ERR, event->type); /* report the entire OICR value to AUX driver */ -- 2.34.1