Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <793b7cd9b229bc9427539c683524572259f2893b.camel@perches.com>
Subject: Re: [PATCH 1/5] x86/alternative: simplify DUMP_BYTES macro
From:   Joe Perches <joe@perches.com>
To:     Alexey Dobriyan <adobriyan@gmail.com>
Cc:     x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org
Date:   Sun, 13 Mar 2022 20:21:15 -0700
In-Reply-To: <Yi4zdkj4Ye4iVj7J@localhost.localdomain>
References: <20220311144312.88466-1-adobriyan@gmail.com>
         <e9c77d12092a4f048992f67d3fa0cf363b8614d4.camel@perches.com>
         <Yi4zdkj4Ye4iVj7J@localhost.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 2022-03-13 at 21:09 +0300, Alexey Dobriyan wrote:
> On Sat, Mar 12, 2022 at 08:36:11AM -0800, Joe Perches wrote:
> > On Fri, 2022-03-11 at 17:43 +0300, Alexey Dobriyan wrote:
> > > Avoid zero length check with clever whitespace placement in the format
> > > string.
> > []
> > > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
> > []
> > > @@ -66,13 +66,10 @@ do {									\
> > >  	if (unlikely(debug_alternative)) {				\
> > >  		int j;							\
> > >  									\
> > > -		if (!(len))						\
> > > -			break;						\
> > > -									\
> > >  		printk(KERN_DEBUG pr_fmt(fmt), ##args);			\
> > > -		for (j = 0; j < (len) - 1; j++)				\
> > > -			printk(KERN_CONT "%02hhx ", buf[j]);		\
> > > -		printk(KERN_CONT "%02hhx\n", buf[j]);			\
> > > +		for (j = 0; j < (len); j++)				\
> > > +			printk(KERN_CONT " %02hhx", buf[j]);		\
> > > +		printk(KERN_CONT "\n");					\
> > >  	}								\
> > 
> > This could also use %02x and not %02hhx
> 
> I doubt as there is funky stuff possible with 255 and such values.

'"%02hhx", u8' and '"%02x", u8' have the same output as the
u8 is converted anyway given the integer promotions.

https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/

> Format specifiers aren't the purpose of the patch anyway.

IMO: If you are already touching the lines,
     you might as well fix it at the same time.

cheers, Joe