Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Mon, 14 Mar 2022 09:08:42 +0000
From:   Marc Zyngier <maz@misterjones.org>
To:     Greg KH <gregkh@linuxfoundation.org>,
        "A. Wilcox" <awilfox@adelielinux.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [BUG] arm64/m1: Accessing SYS_ID_AA64ISAR2_EL1 causes early boot
 failure on 5.15.28, 5.16.14, 5.17
In-Reply-To: <Yi7iRSHaFGsYup1p@kroah.com>
References: <32EA0FE1-5254-4A41-B684-AA2DEC021110@adelielinux.org>
 <Yi7iRSHaFGsYup1p@kroah.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <1f0b74caa45a1d73af68eab8dcc15485@misterjones.org>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022-03-14 06:35, Greg KH wrote:
> On Sun, Mar 13, 2022 at 10:59:01PM -0500, A. Wilcox wrote:
>> Hello,
>> 
>> I’ve been testing kernel updates for the Adélie Linux distribution’s 
>> ARM64 port using a Parallels VM on a MacBook Pro (13-inch, M1, 2020).  
>> When the kernel attempts to access SYS_ID_AA64ISAR2_EL1, it causes a 
>> fault as seen here booting 5.17.0-rc8:

[...]

>> This is because detection of the clearbhb instruction support requires 
>> accessing SYS_ID_AA64ISAR2_EL1.  Commenting out the two uses of 
>> supports_clearbhb in the kernel now yields a successful boot.
>> 
>> Qemu developers seem to have found this issue as well[1] when trying 
>> to boot 5.17 using HVF, the Apple Hypervisor Framework.  This seems to 
>> be some sort of platform quirk on M1, or at least in HVF on M1.  I’m 
>> not sure what the best workaround would be for this.  
>> SYS_ID_AA64ISAR2_EL1 seems to be something added in ARMv8.7, so 
>> perhaps access to it could be gated on that.
>> 
>> Unfortunately, this code was just added to 5.15.28 and 5.16.14, so 
>> stable no longer boots on Parallels VM on M1.  I am unsure if this 
>> affects physical boot on Apple M1 or not.
> 
> What commit causes this problem?  It sounds like you narrowed this down
> already, right?

This really is a Parallels bug. These kernels run fine on bare metal
M1 and in KVM. QEMU was affected as well, and that was fixed in their
HVF handling. HVF itself is fine.

So this should be punted back to the hypervisor vendor for not properly
implementing the architecture (no ID register is allowed to UNDEF).

         M.
-- 
Who you jivin' with that Cosmik Debris?