Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa641092-98e6-114d-b423-13e0bff248fa@amd.com>
Date:   Tue, 15 Mar 2022 13:15:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v6 10/12] perf tools: Improve IBS error handling
Content-Language: en-US
To:     Stephane Eranian <eranian@google.com>
Cc:     peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
        jolsa@redhat.com, songliubraving@fb.com,
        linux-kernel@vger.kernel.org, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20220208211637.2221872-1-eranian@google.com>
 <20220208211637.2221872-11-eranian@google.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20220208211637.2221872-11-eranian@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFZRVS9ZS0xVaXlTaWIzeHNIQUlnZ3RhOW9aMjVLem1pL2FXWUFiMGlvdnhH?=
 =?utf-8?B?dFJpRnEwdGpvRkJUQ2RuTVZuR1pXN1hkeDBzMmYyVWtsWnJkK20yMTN2QU1p?=
 =?utf-8?B?NDdKTGxHVU1OaXB5Y3ZPREIzazBBTHJzY2pCdXRyVzRVck40Vk4vNVFBN1FL?=
 =?utf-8?B?U3NPY09Fbzg2Und3b0xLMktOM01MRVFRNWMvSCtLc0dwU0hCTXZyUXFrbmdu?=
 =?utf-8?B?SEM5RGViVWEwcnlmdlZuajk3ZU51dUVIMXc1cnpLZC9BdXBRZ3RsdnkzZ3BE?=
 =?utf-8?B?cVFMOEZUVnBnekZVMWVKL21JZCtQaStxZ240S2FQbjF1VmdSUzFLN0hJaG5I?=
 =?utf-8?B?THJSZS9ES2xnZkFuaS9nYkQ1dVFJdlBqd3Bib2xSU08xZFpiTklWS25pNlJz?=
 =?utf-8?B?VDl0UjZvSUxKV2JrdCtqOUNwZ0pLaUN6dUJ3R2REem5hVkJ2SmVZRnVEQlRh?=
 =?utf-8?B?NG5jcC85M0l2WDVUdjJjbGFidmhoQnVRTEFoakIwVVhwZjRMVlVvRjVOVHlP?=
 =?utf-8?B?MnBUZGdkWTRDUXNNQytZLzI3WFlyTHZXUkZBN3pjZlNUTXVNWG5kYTV1K2w0?=
 =?utf-8?B?OHc0cjVPK1NWcTdGME1JZE5PQWlKVzNucTVSdFZzRUtCWnllL1hQdTJQOUo5?=
 =?utf-8?B?cVplV2krUlFtanFMSnU4SzEwTVRtelA2WFVTVWdoR3lFbVhZUVJGSXhiTHc5?=
 =?utf-8?B?bWxyS2VUbVhlWnJ6QXZSVVJkYVhvckpxektiaXFOalRhZGdWaytRZ0ExNmQ3?=
 =?utf-8?B?VGxoMFFVY1FaNmJrR0dKdlZSVTZ0cXJFZUFyTDhIYllHL25PMjRFaUxHWHJ1?=
 =?utf-8?B?S254cGNWMXlwaC81eHkrNy9xTFNqTHQwSURlMzQ5MzRmL0hlUldZK1VDSkp0?=
 =?utf-8?B?bTdkdXpDNkgxMnM2aElPQ0lBZ0VQQVlIcHlEQ0ZJY1EwOW9yNW4vNG9vb1BI?=
 =?utf-8?B?VEZLalJ0bXo4VGFhZGpUeTZqVUl3bk9VN1FxYXoxVEx5aHNnSm5TdzhWWlow?=
 =?utf-8?B?ZjR4WFUyVU8xRVdqQmZMeEh3WC9CcTU4ZUZnRnc1NnlDVis5Y2tZQ1p6b1Nw?=
 =?utf-8?B?dStpYit1WWh1L3RaakhJWGtlSTRVU0JFRWlRZGJtbXlOd3BPMjJqdUcxVURY?=
 =?utf-8?B?cEpoTjZuL2djR3Q3SURscnF4bTFpRm1RL1ZmVlZkNWF5WnlmalhlbGtwLzJO?=
 =?utf-8?B?ZHplWXFTc0NBMytBZVdUNWRGdWlocXlkVkdEN0s2Q2xRUkZLdEdyTUlaSHEy?=
 =?utf-8?B?enc2M0o5N2dyTnVUNzkxSGlXZkZJWHEzaDNSakN0Ny9HUFBUdE1Wb3NLdVpV?=
 =?utf-8?B?bzFGU05TV2ovQ011RnVXSDh4WWN5MWY1VXpWUWxyaVhac2tQQ3djbFdtTjYr?=
 =?utf-8?B?clFPdW5UYW8vWndOUmFLS3N3dlFNMHJpcGxuSW1xZkQzdkk2dk5aTEFvSno2?=
 =?utf-8?B?WE85b3grQmVsNGNSVTFwS05SNklTR0ROZG5WdEdYMFVGTkpZb3VFRkpDd0la?=
 =?utf-8?B?b3hvN1hVcVYvSzNtWVg2dWVhM1hiRzJYM3hNUXNzcGthUVR5djRUQ2VtSlpq?=
 =?utf-8?B?VEo1RU5xRDRrZ3QyaGIrWCtjc3E3akF6c1BvU0ZGenQyak9WR3NMN2NSUUdt?=
 =?utf-8?B?eDdodWo0Sko3K2VpN2FPMFE4QStLZlBvb2t5TVFVSTlQeVdxeVVMbXo5bHBp?=
 =?utf-8?B?bWJCUkFuclZvRGwvY0hqMFdHUWxEVXpKK2tuZXhWMlpmbGFIMnMyRFpaQldq?=
 =?utf-8?B?bjNVM2dSOHZIUFN6RlkraFZ4R0s5VWoyT3luT0pVdm5wOEdOeElPMDU5eUov?=
 =?utf-8?B?YWZ2Tm1SblAzaG5Fbi8zQUwyUjlqaURyU3dScHkwZDRsQnVpenRSQ1JjNGpt?=
 =?utf-8?B?TEJ2NURiTVRGQlB5VTZKU1Exd3p2Zk55d3RDZGZiZ25DNjhmNXNTZjdMSGpk?=
 =?utf-8?Q?dD8E815zQ6UjzjUahiNwXr94WBs3ETMM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10597c64-8c09-4866-5519-08da0657dcd8
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3053.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 07:46:06.7339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eioXNsIK0Mqp9o+IUlAeFBOksckvFmzRuCVNP9kwPHRtsZQgQHUkD2PuMra68EH5a1yta9NG1y6rOx/qJkJwow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2762
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Stephane,

On 09-Feb-22 2:46 AM, Stephane Eranian wrote:
> From: Kim Phillips <kim.phillips@amd.com>
> 
> improve the error message returned on failed perf_event_open() on AMD when
> using IBS.
> 
> Output of executing 'perf record -e ibs_op// true' BEFORE this patch:
> 
> The sys_perf_event_open() syscall returned with 22 (Invalid argument)for event (ibs_op//u).
> /bin/dmesg | grep -i perf may provide additional information.
> 
> Output after:
> 
> AMD IBS cannot exclude kernel events.  Try running at a higher privilege level.
> 
> Output of executing 'sudo perf record -e ibs_op// true' BEFORE this patch:
> 
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (ibs_op//).
> /bin/dmesg | grep -i perf may provide additional information.
> 
> Output after:
> 
> Error:
> AMD IBS may only be available in system-wide/per-cpu mode.  Try using -a, or -C and workload affinity

This patch seems to be causing regression to perf python test.

Without this patch:

  $ sudo ./perf test -vvv 19
   19: 'import perf' in python                                         :
  --- start ---
  test child forked, pid 145391
  python usage test: "echo "import sys ; sys.path.append('python'); import perf" | '/usr/bin/python2' "
  test child finished with 0
  ---- end ----
  'import perf' in python: Ok

With this patch:

  $ sudo ./perf test -vvv 19
   19: 'import perf' in python                                         :
  --- start ---
  test child forked, pid 144415
  python usage test: "echo "import sys ; sys.path.append('python'); import perf" | '/usr/bin/python2' "
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
  ImportError: python/perf.so: undefined symbol: perf_env__cpuid
  test child finished with -1
  ---- end ----
  'import perf' in python: FAILED!

Thanks,
Ravi