Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3601180pxp; Tue, 15 Mar 2022 02:08:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAVYeJVdx1d1USR7fXtBoc9dc6VOXSqWBMmUhuTR6u8GkfHdR3UVtuO1mBKdWKssl79Xnq X-Received: by 2002:a17:906:5d07:b0:6db:ab5e:794c with SMTP id g7-20020a1709065d0700b006dbab5e794cmr14829310ejt.678.1647335316860; Tue, 15 Mar 2022 02:08:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647335316; cv=none; d=google.com; s=arc-20160816; b=R0ajj9oOd/8qVWhY7FP5VcipTS1oJWlZLcsHl8Er8vznJti6YVMJJuxblPGDW81pC6 F6M6Clw8FZqHJr9kM4dU4uwa1EHclUXb2bW6/IUZvJliKgbCqGlpnfGa2F1/ESc26FN9 aMZvKDTktHA/R0wpL4GxCqHk9BBjIQmcte7WLmnwPEhluHa6Wzo2HkoZieEVF38ZYbUo AQNLlMQQ5PEOxTMqdo7yNfRgrQfZyJYcge0oVvqPZFzCdK4WYTDHSgEGGSBjsDyvmR8D RIfwlvcE4VlUj3WrrWZ9CvkHJTU/YyqjbKXDbpskLOunUMLzlke70YKZJ0DQW0Ycqq0s 3WdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1HO1vz/xV+QIkQNSxMGo2uNBhGQ1sWfxTeeLC3x5UsA=; b=dt2dGBzSHSCs09xTXXOQR9BK80KrfR3tLPA7Uv+IJ3QBLFY9rnx/fMFYWos8dk5Ni+ zhP9u/HmPcSlFk/H9KOFR8alVkWLaki+FHAxI7mzv0v+uIOKfcZhz74VnoQSktTzNh3e GOuLCZwd4vJ6amjRs+kzGKwGfNVOpCJfiJOPqlm3jUrog1q24LQCoIhhxXqiKKwoU/c2 YIwRx5aM2wjDXUoeyHZAGmoMw4T1MLV1D4HsD2BlOMxIERAwWaUUBe9PmXPR0cx5Gpm2 fcOcRHiJHqIMF5qrbpjkio4AMLmb+fyNfQfAO+75H2VV4fsm3E5tftgYTgkm1SavNgpL tjJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=O6T6VZFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020a1709062cce00b006d09de6c320si9857911ejr.344.2022.03.15.02.08.11; Tue, 15 Mar 2022 02:08:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=O6T6VZFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345636AbiCOHva (ORCPT + 99 others); Tue, 15 Mar 2022 03:51:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232675AbiCOHv3 (ORCPT ); Tue, 15 Mar 2022 03:51:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B5A812AD8 for ; Tue, 15 Mar 2022 00:50:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 230DBB81115 for ; Tue, 15 Mar 2022 07:50:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34440C340EE; Tue, 15 Mar 2022 07:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647330614; bh=SYyFnHdQnLb5UOzpXR0K5y/08yWJ9rcxPxc2nwwQ/y8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O6T6VZFe4yMs+yJ3dTApjuZKh6DuqkJqvBuYuEn7wPImC7QrC5P0XRqx/U/yUBZ90 UxH1vGFONm9oB7+p7hWaqh6kuwxMNAG3nY+CVvFmyQVzfvC6Jzo3F9hr3kzXArRbE7 tRzx79xo9+qp/BldrCp745BZHB6vc8P5TztKKDnk= Date: Tue, 15 Mar 2022 08:50:10 +0100 From: Greg KH To: butt3rflyh4ck Cc: Li Fei1 , LKML Subject: Re: [PATCH] virt: acrn: fix a memory leak in acrn_dev_ioctl() Message-ID: References: <20220308092047.1008409-1-butterflyhuangxx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 15, 2022 at 03:36:11PM +0800, butt3rflyh4ck wrote: > Ok, thanks. By the way, I want to explain, Firstly there is just some > parameter that should be freed before func returns the -EINVAL error > in the patch. What patch? I see nothing here :( > I think it was correct, no need to test it. And secondly the commitor > Li Fei1 also reviewed the patch code. finally I am sorry that no arcn > hso hardware to test it. I still have no context at all. Please properly quote your email threads so that we can all understand and respond properly. thanks, greg k-h