Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3619959pxp; Tue, 15 Mar 2022 02:43:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnVdPXXo8fsbVDxfnodPHqz+zsRVWorKSYm7A75l0oB8LtaGVvKN7AYiDKue3ciNRMnQ0c X-Received: by 2002:a05:6402:2350:b0:418:50c6:211c with SMTP id r16-20020a056402235000b0041850c6211cmr16273996eda.291.1647337387982; Tue, 15 Mar 2022 02:43:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647337387; cv=none; d=google.com; s=arc-20160816; b=fWSEkYlw5DYgAVkZwQDDTuMHD4pjGV8snkj5ZMoOWgc9pzX4Zm8wSUuHz2N6PzcUDw RZH3aY0P693bXJpP5jk/WnMar0OcDFv8ISHWz8j6HZO7IVvqJced5lzjVddCbImAzlkI yjF41DXwXjEzuME9pjmA85+9mh/soQuQtyLk32JZX0mXdb577yuHGWliLukgnpQ/WNwB V3rWwT2Z1vRo5XARagSaacWCbYgkg0B1r3Dmo+UZGg7xXIG8h2ngIfx3vDWgiWQRxJ5f l/oy6k8abuovCpWZ6N09zk5Ev8JneTVhKz/MY7r/Ha3Hj4hp59YxFVfWpzls2VkSvdBq iccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DUrggfzVKufzmWoIKvZEPz4GO4OdeAwImi0Sw1cUPLY=; b=HCsjaiydHBORVvpg3muEEHIsHGJWRYD/BokaolDiaDwRJ+f3zmaZ/OTBVyj0Xhduch xxE0AulbxTE2uctBKQe5WDMdm0hT1EsNNvmxSVlpxSVaD/N53ioJMMIe0jOIMgvLdsly eqf6NV7wbCGHPQ9oa4tfVisSTHPQ6+DC5XP8JPwb3jle+KwAYlF5yP15UN+JAvDeH9no j30z/Q0ooet9oO5EmqUfxGAepblswrO6Ffj90NhAjiCo440ScWTTmNEdS6ZihIbJGVGT wzipz40zLzIdMHiUhyIG7mUQr28NawmldLL4piraIjtEdsYBY9BwvltRNhYGj22xIemw ixQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Pp9U4iBz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a05640235c800b0041858897957si6839106edc.181.2022.03.15.02.42.39; Tue, 15 Mar 2022 02:43:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Pp9U4iBz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344274AbiCOBYi (ORCPT + 99 others); Mon, 14 Mar 2022 21:24:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344258AbiCOBYh (ORCPT ); Mon, 14 Mar 2022 21:24:37 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CBE424587 for ; Mon, 14 Mar 2022 18:23:25 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id f38so34429165ybi.3 for ; Mon, 14 Mar 2022 18:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DUrggfzVKufzmWoIKvZEPz4GO4OdeAwImi0Sw1cUPLY=; b=Pp9U4iBz1c7RdL74LrziYiz0K9sqGHBLLfaiw7yuCobsSclKVyzEwCqiG22sJkP0ga swsO3N/Nup5cLeDeza3pXkR4oTq3FVm8FeVlfhRTxrlvcN2DltmKfxQ2lrv0pFdZyi/4 KwTLKqnuXPMXPHVuNysLSe0n6a6itKcOiQwMOuYJlQZZVRrYznnLIgsa8ZaJBtW5SRXc eOKD5h6tt1tikqIrk6zqwZTtljBgVxHfnYNYKeAWO/632CuHRAVakI18zekwRWndDpbT DYmmd3dRbCAmcGmvwebbUtivtqCj5CJvBkD0FGRR9BYQehHQPykOwLCJ/k/Vj6OlqawU 2pDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DUrggfzVKufzmWoIKvZEPz4GO4OdeAwImi0Sw1cUPLY=; b=ddX8Ycn+emqFI6aHR+Ap2mcduyil3wFA6/8YMDYeDy8UKsRG0qkutcMQOBENEoXooN BZPA76hLEO8vS7QPnKUL4rDRmqLFQWKgArs8wciMxQxMNDNyiOTXcBX97xH7UXbUPA5A AcvKDgpy2ws3YPeSM7yil0V/RmuGfy/QYmBSsKCHL8GwwcCx8885wbj76IWL4jpwOQPH vzUIPXN2pd3bzX9iY+tf9HdO96QaAsztDn9PYeKJS903lGunXD+dbyvO1DoV5+2OTN/5 BsjfcWyuOiIwRm/OVYWFnkatKTAlLVS3g7sF9z3rxQwYJmsFKGzogQs5lGNGbFi3N1DI sLgA== X-Gm-Message-State: AOAM532MBcH6y7nZ3VpJ/DBcU8U6ZKy6/RlJFLZuhrHCQQ139b2b9ZNk k7HFl2Z1gI8zi+UK8Nyhclnj6b7FGV41B44PvGe/xw== X-Received: by 2002:a5b:dc5:0:b0:624:f16d:7069 with SMTP id t5-20020a5b0dc5000000b00624f16d7069mr20041868ybr.295.1647307404617; Mon, 14 Mar 2022 18:23:24 -0700 (PDT) MIME-Version: 1.0 References: <20220307115116.25316-1-linmq006@gmail.com> In-Reply-To: <20220307115116.25316-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 15 Mar 2022 02:23:13 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: nomadik: Add missing of_node_put() in nmk_pinctrl_probe To: Miaoqian Lin Cc: Lee Jones , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,SUSPICIOUS_RECIPS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 7, 2022 at 12:51 PM Miaoqian Lin wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. Calling of_node_put() to avoid > the refcount leak. > > Fixes: 32e67eee670e ("pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree") > Signed-off-by: Miaoqian Lin Patch applied. Yours, Linus Walleij