Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5609a43a-afbe-7629-b84d-75ace62da4fe@amd.com>
Date:   Tue, 15 Mar 2022 11:53:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v6 10/12] perf tools: Improve IBS error handling
Content-Language: en-US
To:     Stephane Eranian <eranian@google.com>
Cc:     peterz@infradead.org, kim.phillips@amd.com, acme@redhat.com,
        jolsa@redhat.com, songliubraving@fb.com,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        linux-kernel@vger.kernel.org
References: <20220208211637.2221872-1-eranian@google.com>
 <20220208211637.2221872-11-eranian@google.com>
 <CABPqkBSzc167wNbJpWu7msfZ-KrGu-nMtFdw-naN+M7Q0py-vA@mail.gmail.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CABPqkBSzc167wNbJpWu7msfZ-KrGu-nMtFdw-naN+M7Q0py-vA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXNwYWE3MVoza1JwTW1uUk0waDZCYWJXVi9KakpCTi9QMDlBMWNtSjIxRGFY?=
 =?utf-8?B?aENUcUF4cHUxUEtnL0ZBb09iOVlxRmZMM0xWNXdYZUd5K3FXbFRGZ0ZRZlFs?=
 =?utf-8?B?VTZOMmVLeGIwd05tZk10ZEdmMHoyMkZjWWZBL1UxNm5BQWU0ZVdQR3k1UXlM?=
 =?utf-8?B?dm1yY2xTNC8rL2puUDBmdGdPQkRKdVp0Rll2T1JlRXl1aEdvb3QxL2hwUkU1?=
 =?utf-8?B?WEFQYzZrMTg5LzFmRmRJMVZqV0FRWXBWRXZxbGlSaXdhT0NCWklIZjIvaG8z?=
 =?utf-8?B?amxMWmhMMjdxWkxaTm92SmRnNkMzeVlBZTZsWkhDbnBTNnFCWGduVk5LdWJS?=
 =?utf-8?B?WFlmZ09vRitUM3ZWRGx0SkRURDdlN2JWMkFSd05PbDRkRENkdThFMzhmcFBY?=
 =?utf-8?B?S05MN29ZNE40TXFSanJabUJqQUdWOGdqdVNqZmJHRFViTll1dVM3TUE3akMv?=
 =?utf-8?B?YWp3UDRVZWhudkRJUzhjMjFCYnBKMFBIcFR6dmF3dC9DeFRDZnNsek8yZExq?=
 =?utf-8?B?T3haLzJuTTNTRFBBYnlMNk1ZU3JEYk9Zd0UvVHk1YXBPVGVWR0RpMzJhUVFn?=
 =?utf-8?B?b25NZyswZ05zaUVQSG54ZTkwbGV3OUFOSC9UWloycERXOEd3TDVoZTlFY1d2?=
 =?utf-8?B?dWZUZ1hWQnlDK2psQ2V2TUlSemFaWjJKUmdVdEZlRVBnK0R5aTkvSHQ3dFdr?=
 =?utf-8?B?cUVzYkhDeHpxdC9WYXR2R0xKV0ZPZVhSaXJWdjc1TUZPNk5IZW5rcUI0bWZI?=
 =?utf-8?B?Mm94L1NRYnduVHJJV1BSMnhJQ1Q4bElvQ0tla1NUb0pzRjMvQTF6UnNIeEZI?=
 =?utf-8?B?R3JNYkZFZHppeHg5SjV4M2ZlVEthOUxIcUdybE5Bc3FwQTE4ZmhrbkNKZWhP?=
 =?utf-8?B?WTZRR1hOQWF6ODR5alJ3VWt5NjZIK2MwOEdYaDRRVCtGc2pNWWU1M2tqc1Vs?=
 =?utf-8?B?TUJ3WldnV0Mzb1BRQS90NGczUkZXRHBxTTlaNVdub3N3TmoyMGcwWXF4ZEdR?=
 =?utf-8?B?bXYyRUNFTlgzTUZ1NE9rVHNTQlJjQi94di8yNGJvSmxaVWlaWFA3SXUyL1N5?=
 =?utf-8?B?a2Y1UmJwbktLN1owMlFWRXQ1TXIvak9FWUxncTlTZE8wQjVOOEhjUWJIZ2tS?=
 =?utf-8?B?R2ZHTEYxUUFobVdyYUI0RDlWMG1wOVZuakZUUTBXT2ZpTWNtRXpLVmlGU0kr?=
 =?utf-8?B?UHhjUlRYcFdBTXpiUjVBVXVCSWFzWHN6RW5Ia1A1bVdLZ0FHUFd3eUl6SHFP?=
 =?utf-8?B?clpZRW1EQzd4Z1QycllGZ3Jza05wbEd3RE9ENWRiNWcxdHQzUFBqMUlOS0Zu?=
 =?utf-8?B?M2tjYm1VaS9YQmNaMlMvd3FBbkNXdUhTOG5XVFlEU2ZZNFNNMDhwSWs4M1hy?=
 =?utf-8?B?Uk1GVFdKUGdnVDIxckNpU1NReDBrMUNHdmdZeENxVGVCeTVGY3NKVnpYQ0l1?=
 =?utf-8?B?U0cxL3IyL3BlQkpNUGFuSmFVMXBWcS9Yb09uSXJ1Umd5V3g4dGllRHRudHhi?=
 =?utf-8?B?cU1naGFyNlVFRy9WcTNKc243MGIyci9KU0EwRGpZOHJDMlpzbk81Ky9VQU9C?=
 =?utf-8?B?dlRqOEdseUR3MTNqMkFEMUJuWGhqVjNURGxZRW9tWVNvWjU4OGYwejg5ZmZJ?=
 =?utf-8?B?R0lPZmFaQW8reGE5b0NuUWRvd1NQOCtOcTZNWnZzZC9zMVZheUphVHhZbk1P?=
 =?utf-8?B?TkgyaGJaeHhWQ2dMWGFQVjRqY3dsN0JXT3NRcjVRZUdaaEg1bEhuY3lSVlVB?=
 =?utf-8?B?L2FNYlhuUGdaZWh6d1UwbGtnUWlKalVEQy9RV3BSUS9FR0NJYXlEQWwva2FJ?=
 =?utf-8?B?dWJmSXpvSjNkQWFSMUlWTmMxY3dSRy9rRVBUeUdBRGNtZ3A5bExvdTFxVmVa?=
 =?utf-8?B?QWFNdGZ3Zm1DTjRtYWZEdEQxRXRYWnZZbjNSb3FSSTRQV3Awa1JpcW5mL243?=
 =?utf-8?Q?dZdha84KW4D9PcrY/bhImxS2b/b4cIJ9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fe2902b-a792-4697-7560-08da064c5828
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3053.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 06:23:39.6892
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3FxxOZmu4uG+xQhWpLq55IyOcHa6SZ5P6gfoSEkrnxE2JXqb8RMMZeApnZefnfPPhRrYp2mGdymhZtpj/oJCxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB2996
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +static bool is_amd(const char *arch, const char *cpuid)
>> +{
>> +       return arch && !strcmp("x86", arch) && cpuid && strstarts(cpuid, "AuthenticAMD");
>> +}
>> +
>> +static bool is_amd_ibs(struct evsel *evsel)
>> +{
>> +       return evsel->core.attr.precise_ip || !strncmp(evsel->pmu_name, "ibs", 3);
>> +}
>> +
>>  int evsel__open_strerror(struct evsel *evsel, struct target *target,
>>                          int err, char *msg, size_t size)
>>  {
>> +       struct perf_env *env = evsel__env(evsel);
>> +       const char *arch = perf_env__arch(env);
>> +       const char *cpuid = perf_env__cpuid(env);
> 
> 
> This code dies for me on the latest tip.git because env = NULL and
> perf_env_cpuid() is broken for NULL argument.
> I don't quite know where this env global variable is set but I hope
> there is a better way of doing this, maybe using
> the evsel__env() function in the same util/evsel.c file.
> 
> Similarly, the is_amd_ibs() suffers from a NULL pointer dereference
> because evsel->pmu_name maybe NULL:
> 
> $ perf record -e rc2 .....
> 
> causes a NULL pmu_name.

This should fix the issue:

@@ -2965,7 +2989,7 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target,

 struct perf_env *evsel__env(struct evsel *evsel)
 {
-	if (evsel && evsel->evlist)
+	if (evsel && evsel->evlist && evsel->evlist->env)
 		return evsel->evlist->env;
 	return &perf_env;
 }

Thanks,
Ravi