Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3789605pxp; Tue, 15 Mar 2022 06:26:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNcv6GvZz+fALszkP/6xB+1i6SWrnAZMrUqQjPvp/v2Ogj6zgsv4ymtBumvlevb+ZADB3K X-Received: by 2002:a05:6402:5208:b0:416:ce01:f9b5 with SMTP id s8-20020a056402520800b00416ce01f9b5mr19665175edd.275.1647350792772; Tue, 15 Mar 2022 06:26:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647350792; cv=none; d=google.com; s=arc-20160816; b=xDkTRGkiZjLaKd+l6BuIHTvAox8Uld4Ibqwi2EQ5TYhExANK+ZppZZa4qslw0zA5Ty KxcAOlkJBtz0CC9A50Xit3thE+ibGgl+qubf/+0h4GU1quyp5G1M3UKrCTJg/j5CoklI tfRzmV5YqLTqKKHXUKSduDi9Ie14u/7f5RHgnDBBDNXtUgkhiiUFEsjaoKOUtj8rJt7N KKc79nLFXZcsdJKQ4noC7YDwhF6cIjUOJgeEuD8DE2t9y2Kk/CDD9Nlwcfw7Vb7zXYfH tgGADourm6dUR/UVHq5+uH4rZlJjb3berCuTkeUU8ZTtouJmy+wDN6x2hzbFxYi6e3Lu 31tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=p3GbIqA1ogxBaIo4WAMLvufoT+z35GSBliOdfnsBJQ0=; b=sW0uaRmfgNN313Xg9S1N1v6fUwvvNhPmK0xZwRvR8z3XoakiCNKwSRZDi3gYkkr3Kc G5olqrisqHaAcTR5PmYlEaZp5xzMjGWKUjjnCfS3sLz31QVTk9XiHbKWLFguRIiZedxa 7a/5Uul3LTyCXjffcJagR7nTC9XZ84tVPkX32w9elbIZRkQHlZ6PhqPV3EwKebAqmZql zakjsHdw/dhw8xdEtqL6UGh7V4HwJH9M7om9KwrthXajoJGLivKPuOgRZ9W7Tyoszfkk RvBFd/UuyJrNcAPCLYSXPe/dZnM0s831ugkSBQ2cHZpx2vWElko9LHD58YQ1+9Py7BWa UkDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DbjIVQma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dy25-20020a05640231f900b0041644faef40si11188743edb.236.2022.03.15.06.26.03; Tue, 15 Mar 2022 06:26:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DbjIVQma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241611AbiCNMZj (ORCPT + 99 others); Mon, 14 Mar 2022 08:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242274AbiCNMSy (ORCPT ); Mon, 14 Mar 2022 08:18:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D66C7340CC; Mon, 14 Mar 2022 05:13:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 33E3BB80DFE; Mon, 14 Mar 2022 12:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F002C340E9; Mon, 14 Mar 2022 12:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647260032; bh=vmDDCMyWCdMpPc7ZXHn3GOmsBNQpCxT7+naX+1yMc0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DbjIVQma97Ih9mXVlL/gKjk/7n9HDZV2TE44Wz1AQ2Yu5trBK1RPvDeF6BMmrfunN ISxds5bPGT1CASmwIELEMM57eED+whcvsHLXIr8PAHn8rWtmJJfwKrNWXtyP5cPMNB 3s+a1E3s5ZOm9r+A5XWEUy7vdd7xNUpW3v1vxjeg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Grzegorz Siwik , Jedrzej Jagielski , Tony Nguyen , Sasha Levin , Gurucharan Subject: [PATCH 5.16 038/121] ice: Fix curr_link_speed advertised speed Date: Mon, 14 Mar 2022 12:53:41 +0100 Message-Id: <20220314112745.192684762@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112744.120491875@linuxfoundation.org> References: <20220314112744.120491875@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jedrzej Jagielski [ Upstream commit ad35ffa252af67d4cc7c744b9377a2b577748e3f ] Change curr_link_speed advertised speed, due to link_info.link_speed is not equal phy.curr_user_speed_req. Without this patch it is impossible to set advertised speed to same as link_speed. Testing Hints: Try to set advertised speed to 25G only with 25G default link (use ethtool -s 0x80000000) Fixes: 48cb27f2fd18 ("ice: Implement handlers for ethtool PHY/link operations") Signed-off-by: Grzegorz Siwik Signed-off-by: Jedrzej Jagielski Tested-by: Gurucharan (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index 572519e402f4..b05a5029b61f 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -2314,7 +2314,7 @@ ice_set_link_ksettings(struct net_device *netdev, goto done; } - curr_link_speed = pi->phy.link_info.link_speed; + curr_link_speed = pi->phy.curr_user_speed_req; adv_link_speed = ice_ksettings_find_adv_link_speed(ks); /* If speed didn't get set, set it to what it currently is. -- 2.34.1