Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 23:04:08 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <vincent.mailhol@gmail.com>
Cc:     Max Staudt <max@enpas.org>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220314220408.hn4vdohtjdbfoaqo@pengutronix.de>
References: <20220307214303.1822590-1-max@enpas.org>
 <CAMZ6RqJZObevKPc29jW+m6i0eAgestTbw8KCPXxSGHzSXK7cRg@mail.gmail.com>
 <20220309135414.34f77251.max@enpas.org>
 <CAMZ6RqJJ-PO=WeFeuXk4iC9GHLXz_ZMWtsVCm6sGVGbmeE5U1Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jairfwongtmk2mz3"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqJJ-PO=WeFeuXk4iC9GHLXz_ZMWtsVCm6sGVGbmeE5U1Q@mail.gmail.com>
Precedence: bulk


--jairfwongtmk2mz3
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 09.03.2022 22:49:49, Vincent Mailhol wrote:
> > But rx_offload needs the mailbox_read function, even if it's a dummy,
> > because can_rx_offload_add_fifo() checks:
> >
> >         if (!offload->mailbox_read)
> >                 return -EINVAL;
>=20
> I think that there should not be a dummy functions like this one.
>=20
> Either we agree that using can_rx_offload without implementing
> the mailbox_read() is OK and in that case, the can_rx_offload
> framework should be modified to allow mailbox_read() to be a NULL
> pointer.
>=20
> Either it is not the case and you use the more classic
> netif_rx().
>=20
> And I do not have the answer. I haven't studied can_rx_offload
> enough to be a judge here. Sorry.
>=20
> @Marc, any thoughts?

Use can_rx_offload_add_manual() instead.

> > > > +/* Send a can_frame to a TTY. */
> > > > +static netdev_tx_t elmcan_netdev_start_xmit(struct sk_buff *skb,
> > > > +                                           struct net_device *dev)
> > > > +{
> > > > +       struct elmcan *elm =3D netdev_priv(dev);
> > > > +       struct can_frame *frame =3D (struct can_frame *)skb->data;
> > > > +
> > > > +       if (skb->len !=3D sizeof(struct can_frame))
> > > > +               goto out;
> > >
> > > Isn=E2=80=99t this aleardy guaranteed by the upper layers?
> >
> > Copy-pasta from slcan.c - will look into it.
>=20
> Also give a look at can_dropped_invalid_skb().

ACK

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--jairfwongtmk2mz3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmIvu9UACgkQrX5LkNig
010z+wf8COaZnIFyF/cDQMT+ve8a0iwBPignONvdZYfNxHc+rLtj3801S/p2AaDj
oI8HTmCwRyl2HBIXPCyBIiy3YgqiY0kb54FDZqZ9JuvNxTgAj0HtWqS6EW32DYdB
cs7da4RXLR2xyQMr4YizVUePiETHQwu4y4wof3rg2ghdfIBcfZJwqpnm6LfNG9Jn
n2IEY3ntpULQrA08ittg0kvPQAVehJZ0h/1OARpsxyK7P1yrEgdOxgEG1KsIfrfu
RcjRqLhX/h9iu619oTuofcCSzvZgieyXawWgBbP13bgue8fHjKbibKr93Hnv8orp
Bd5CPt6oULFdq775Wu36VSvqJjyMmg==
=KNPb
-----END PGP SIGNATURE-----

--jairfwongtmk2mz3--