Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 12:45:13 -0700
From:   Isaku Yamahata <isaku.yamahata@gmail.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
        Jim Mattson <jmattson@google.com>, erdemaktas@google.com,
        Connor Kuehl <ckuehl@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Subject: Re: [RFC PATCH v5 008/104] KVM: TDX: Add a function to initialize
 TDX module
Message-ID: <20220314194513.GD1964605@ls.amr.corp.intel.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com>
 <b92217283fa96b85e9a683ca3fcf1b368cf8d1c4.1646422845.git.isaku.yamahata@intel.com>
 <05aecc5a-e8d2-b357-3bf1-3d0cb247c28d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <05aecc5a-e8d2-b357-3bf1-3d0cb247c28d@redhat.com>
Precedence: bulk

On Sun, Mar 13, 2022 at 03:03:40PM +0100,
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 3/4/22 20:48, isaku.yamahata@intel.com wrote:
> > +
> > +	if (!tdx_module_initialized) {
> > +		if (enable_tdx) {
> > +			ret = __tdx_module_setup();
> > +			if (ret)
> > +				enable_tdx = false;
> 
> "enable_tdx = false" isn't great to do only when a VM is created.  Does it
> make sense to anticipate this to the point when the kvm_intel.ko module is
> loaded?

It's possible.  I have the following two reasons to chose to defer TDX module
initialization until creating first TD.  Given those reasons, do you still want
the initialization at loading kvm_intel.ko module?  If yes, I'll change it.

- memory over head: The initialization of TDX module requires to allocate
physically contiguous memory whose size is about 0.43% of the system memory.
If user don't use TD, it will be wasted.

- VMXON on all pCPUs: The TDX module initialization requires to enable VMX
(VMXON) on all present pCPUs.  vmx_hardware_enable() which is called on creating
guest does it.  It naturally fits with the TDX module initialization at creating
first TD.  I wanted to avoid code to enable VMXON on loading the kvm_intel.ko.
-- 
Isaku Yamahata <isaku.yamahata@gmail.com>