Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3861832pxp; Tue, 15 Mar 2022 07:44:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOBXVdwS+1fqshhfvh4E0JUJm5u8P68T7MwoGaca2Z7t0aaK0zIq0j3o7o7FmTcjJjMVq6 X-Received: by 2002:a17:907:94ca:b0:6da:b785:f067 with SMTP id dn10-20020a17090794ca00b006dab785f067mr22565136ejc.654.1647355459527; Tue, 15 Mar 2022 07:44:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647355459; cv=none; d=google.com; s=arc-20160816; b=BlQ9wgFbqDqcSiPu2zjaxphGjG+tS5Fdiz4Uiz9YH8DvBAjecF4mDTHOpxtdwZT0Yj /41coSTmdJp8yxNJrjR6lrUQY8KaoOIp4J/+NE62ss5i1IwcU4sb8KBNBOmtO4zzC0X2 3GLWuJqaJPGrB5n/AaTraGVx5w5WapkpNpnFc7MaUuliCyeaul6T3JYUuID4vC49P8be lpQwWFBgwmZbsPjd4CKUAK3i/kfzO6RaNUDV1D5rNxmW+Q02XMbC9J+JbyhEjcRaLE3W KV/kosKhgc4g+SY9dMi8UP5xzuGpAKvD9WuTcF6AwFekLzIRuRV0n82VTb3PXwZx91pL Ej4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nkpgXuqsqwk/HsKD/dEBBJo7QoWRmQbP4u6L3/OXlcI=; b=WMuYx0q03ZkqX001gsR8VMv6SfDQU2MtmvR+pCG2HMy8rOh6p/s14ffhJRMivFjvJf RuFM20eFHaTPgpzHSnwxrjZFtwdn+ugk5N4hXiH/jTKu+5dNgOFSpMSKmYsXMVZihIIA LT0Z18+vGfzAcAsoY9wXiNWF39FmlL7p83hvEYBeJyxrZZGLkIjfiK/8y0qClE3+5JVi aOtLlnaGgeXop3yFu2a/gOcNBXLxvWZAtfA6kwr18U6K6HHURlrPp4rVcGkx7gwYyEXM 2hEfI8GG3wS6OtlBZjCxR69ziASXx5uDBInPzfSllCP9JfeYsZbJ00mNtP2/MSiKgen2 eNXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SG7gS522; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p8-20020a50cd88000000b00413a306e96csi10833390edi.292.2022.03.15.07.43.54; Tue, 15 Mar 2022 07:44:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SG7gS522; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240363AbiCNMEK (ORCPT + 99 others); Mon, 14 Mar 2022 08:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240724AbiCNMD2 (ORCPT ); Mon, 14 Mar 2022 08:03:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4A564B43F; Mon, 14 Mar 2022 05:00:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C27E56112C; Mon, 14 Mar 2022 12:00:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A16DAC340E9; Mon, 14 Mar 2022 12:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647259245; bh=PammZmf/887fjlSTjafG/i4SUvHeL/WS/ItbAgnkW5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SG7gS522zobwPncwwcrX6kvhT2540nbDn2eoiaYcACHeeRchnQADjAM+UBJpNSyh7 xoqUQUkUHjwTy1Fy6RFjh31viLc4hSTandFFcWBb+JzYnjfVCYmJUGP26nw5GTs3L9 HzNTsc3+WBmQpQtg11iQnL4mSJaXssEOjmFCMbf0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Jesse Brandeburg , Claudiu Manoil , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 33/71] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info Date: Mon, 14 Mar 2022 12:53:26 +0100 Message-Id: <20220314112738.859903699@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112737.929694832@linuxfoundation.org> References: <20220314112737.929694832@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 2ac5b58e645c66932438bb021cb5b52097ce70b0 ] The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata") Signed-off-by: Miaoqian Lin Reviewed-by: Jesse Brandeburg Reviewed-by: Claudiu Manoil Link: https://lore.kernel.org/r/20220310015313.14938-1-linmq006@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index cc7d4f93da54..799a1486f586 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1456,6 +1456,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp"); if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); } -- 2.34.1