Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 19:57:32 +0000
From:   Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH v4 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable
To:     Christophe Branchereau <cbranchereau@gmail.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org
Message-Id: <WF3R8R.TU622OO0WUTK3@crapouillou.net>
In-Reply-To: <20220311170240.173846-2-cbranchereau@gmail.com>
References: <20220311170240.173846-1-cbranchereau@gmail.com>
        <20220311170240.173846-2-cbranchereau@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Christophe,

Le ven., mars 11 2022 at 18:02:37 +0100, Christophe Branchereau=20
<cbranchereau@gmail.com> a =E9crit :
> This allows the CRTC to be enabled after panels have slept out,
> and before their display is turned on, solving a graphical bug
> on the newvision nv3502c
>=20
> Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> ---
>  drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c=20
> b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> index dcf44cb00821..51512f41263e 100644
> --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c
> @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct=20
> notifier_block *nb,
>  	}
>  }
>=20
> +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge=20
> *bridge,
> +					     struct drm_bridge_state *old_bridge_state)
> +{
> +	struct ingenic_drm *priv =3D drm_device_get_priv(bridge->dev);
> +
> +	regmap_write(priv->map, JZ_REG_LCD_STATE, 0);
> +
> +	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
> +			   JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE,
> +			   JZ_LCD_CTRL_ENABLE);
> +}
> +
>  static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
>  					   struct drm_atomic_state *state)
>  {
> @@ -237,17 +249,11 @@ static void=20
> ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc,
>  	if (WARN_ON(IS_ERR(priv_state)))
>  		return;
>=20
> -	regmap_write(priv->map, JZ_REG_LCD_STATE, 0);
> -
>  	/* Set addresses of our DMA descriptor chains */
>  	next_id =3D priv_state->use_palette ? HWDESC_PALETTE : 0;
>  	regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv,=20
> next_id));
>  	regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1));
>=20
> -	regmap_update_bits(priv->map, JZ_REG_LCD_CTRL,
> -			   JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE,
> -			   JZ_LCD_CTRL_ENABLE);
> -
>  	drm_crtc_vblank_on(crtc);
>  }
>=20
> @@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs=20
> ingenic_drm_encoder_helper_funcs =3D
>=20
>  static const struct drm_bridge_funcs ingenic_drm_bridge_funcs =3D {
>  	.attach			=3D ingenic_drm_bridge_attach,
> +	.atomic_enable		=3D ingenic_drm_bridge_atomic_enable,

Shouldn't we have a .atomic_disable() as well? If the CRTC is now=20
enabled in the bridge's .atomic_enable, it would make sense to have it=20
disabled in the .atomic_disable().

Cheers,
-Paul

>  	.atomic_check		=3D ingenic_drm_bridge_atomic_check,
>  	.atomic_reset		=3D drm_atomic_helper_bridge_reset,
>  	.atomic_duplicate_state	=3D drm_atomic_helper_bridge_duplicate_state,
> --
> 2.35.1
>=20