Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74afb713-0413-bd49-c3f1-f6a094df2e17@arm.com>
Date:   Mon, 14 Mar 2022 16:34:23 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] drm/bridge: synopsys/dw-hdmi: set cec clock rate
Content-Language: en-GB
From:   Robin Murphy <robin.murphy@arm.com>
To:     Peter Geis <pgwipeout@gmail.com>,
        Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Pierre-Hugues Husson <phh@phh.me>,
        Archit Taneja <architt@codeaurora.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        dri-devel@lists.freedesktop.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220126202427.3047814-1-pgwipeout@gmail.com>
 <3AFD1DD4-AF0A-4ECC-B4F5-E6BD6B9F1BB7@gmail.com>
 <CAMdYzYq06QSmFAwCuTmBYy4LfQAQDxzx2PGc8HOB1iEjxXHGyg@mail.gmail.com>
 <c6766e6e-3c90-f0e6-86b3-4afdf41fbbb1@arm.com>
In-Reply-To: <c6766e6e-3c90-f0e6-86b3-4afdf41fbbb1@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022-03-14 11:31, Robin Murphy wrote:
> On 2022-03-13 12:56, Peter Geis wrote:
>> On Sun, Mar 13, 2022 at 6:13 AM Piotr Oniszczuk
>> <piotr.oniszczuk@gmail.com> wrote:
>>>
>>>
>>>
>>>> Wiadomość napisana przez Peter Geis <pgwipeout@gmail.com> w dniu 
>>>> 26.01.2022, o godz. 21:24:
>>>>
>>>> The hdmi-cec clock must be 32khz in order for cec to work correctly.
>>>> Ensure after enabling the clock we set it in order for the hardware to
>>>> work as expected.
>>>> Warn on failure, in case this is a static clock that is slighty off.
>>>> Fixes hdmi-cec support on Rockchip devices.
>>>>
>>>> Fixes: ebe32c3e282a ("drm/bridge: synopsys/dw-hdmi: Enable cec clock")
>>>>
>>>> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
>>>> ---
>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c 
>>>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>> index 54d8fdad395f..1a96da60e357 100644
>>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>>>> @@ -48,6 +48,9 @@
>>>>
>>>> #define HDMI14_MAX_TMDSCLK    340000000
>>>>
>>>> +/* HDMI CEC needs a clock rate of 32khz */
>>>> +#define HDMI_CEC_CLK_RATE    32768
>>>> +
>>>> enum hdmi_datamap {
>>>>        RGB444_8B = 0x01,
>>>>        RGB444_10B = 0x03,
>>>> @@ -3347,6 +3350,10 @@ struct dw_hdmi *dw_hdmi_probe(struct 
>>>> platform_device *pdev,
>>>>                                ret);
>>>>                        goto err_iahb;
>>>>                }
>>>> +
>>>> +             ret = clk_set_rate(hdmi->cec_clk, HDMI_CEC_CLK_RATE);
>>>> +             if (ret)
>>>> +                     dev_warn(hdmi->dev, "Cannot set HDMI cec clock 
>>>> rate: %d\n", ret);
>>>>        }
>>>>
>>>>        /* Product and revision IDs */
>>>> -- 
>>>> 2.25.1
>>>>
>>>>
>>>> _______________________________________________
>>>> Linux-rockchip mailing list
>>>> Linux-rockchip@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>>>
>>> Peter,
>>>
>>> On my 5.17-rc7 with applied rk356x VOP2 v8 series - this patch makes 
>>> CEC working on rk3566.
>>> Unfortunately it breaks working ok CEC on rk3399 rockpi-4b.
>>>
>>> Reverting this patch brings back CEC on rk3399 - but rk3366 becomes 
>>> with non working CEC
>>>
>>> I'm not sure how to move forward with this....
>>
>> I was worried about that, thanks for testing it.
>> Can you send me the cec_clk rate before and after this patch?
> 
> Hmm, looks like there might be a bug in the RK3399 clock driver - 
> although it's treated as having mux_pll_p as parents, according to the 
> public TRM the CEC clock appears unique in being backwards compared to 
> every other mux of those two inputs. I'm now tempted to test this on my 
> board tonight and see if I can see 24MHz on the CEC pin... :)

Nope, turns out that's an error in the TRM and the mux is fine. The bug 
is between the clock driver blindly assuming xin32k is usable, and 
nearly all RK3399 boards forgetting to claim the pinctrl to actually 
enable the input :/

Robin.