Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-0f1389c2-6d2b-4499-a2fc-3cb93f4d09cb-1647272336831@3c-app-gmx-bap56>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Viresh Kumar <vireshk@kernel.org>,
        Shiraz Hashim <shiraz.linux.kernel@gmail.com>, soc@kernel.org,
        Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: Aw: Re: [PATCH v6 3/6] ARM: dts: spear13xx: Fix sata node name
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 14 Mar 2022 16:38:56 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <20220314034940.rxkgue2kllnqhucp@vireshk-i7>
References: <20220311210357.222830-1-linux@fw-web.de>
 <20220311210357.222830-4-linux@fw-web.de>
 <20220314034940.rxkgue2kllnqhucp@vireshk-i7>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

thanks for for checking the spear-patch=2E

> Gesendet: Montag, 14=2E M=C3=A4rz 2022 um 04:49 Uhr
> Von: "Viresh Kumar" <viresh=2Ekumar@linaro=2Eorg>
>
> On 11-03-22, 22:03, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files=2Ede>
> >=20
> > After converting the binding to yaml the node name does
> > not match the standard pattern, change it=2E
> >=20
> > arch/arm/boot/dts/spear1340-evb=2Edt=2Eyaml: ahci@b1000000:
> > $nodename:0: 'ahci@b1000000' does not match '^sata(@=2E*)?$'
> > 	From schema: Documentation/devicetree/bindings/ata/ahci-platform=2Eya=
ml
> >=20
> > Fixes: 07658d9a659b ("SPEAr13xx: Add dts and dtsi files")
>=20
> I don't think this is correct=2E The above patch is correct=2E The first
> patch in this series changes the names and that's where things break=2E

it's right that my binding will break it, but the nodes are not named the =
right way=2E
And i used the commit that introduces the wrong node-names=2E
Maybe fixes-tag is wrong in this case=2E

> I think you could have added these patches before changing to yaml and
> then nothing would ever have broken=2E
>=20
> Since this isn't a big deal anyway, I think you can just drop the
> Fixes tag here, and other dts patches you have=2E

regards Frank