Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dong Aisheng <aisheng.dong@nxp.com>
To:     linux-mm@kvack.org
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        dongas86@gmail.com, shawnguo@kernel.org, linux-imx@nxp.com,
        akpm@linux-foundation.org, m.szyprowski@samsung.com,
        lecopzer.chen@mediatek.com, david@redhat.com, vbabka@suse.cz,
        stable@vger.kernel.org, shijie.qin@nxp.com,
        Dong Aisheng <aisheng.dong@nxp.com>
Subject: [PATCH v3 1/2] mm: cma: fix allocation may fail sometimes
Date:   Tue, 15 Mar 2022 22:45:20 +0800
Message-Id: <20220315144521.3810298-2-aisheng.dong@nxp.com>
In-Reply-To: <20220315144521.3810298-1-aisheng.dong@nxp.com>
References: <20220315144521.3810298-1-aisheng.dong@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?48B2KY0tLa3PRIpiMeTswaaCKnxaosNoBcJ+dVN+Q7g8lFuPPBtp4F4t9t+Q?=
 =?us-ascii?Q?lCnAhVWn+N9R5NBfcMzdpqr0qINxN5ehgfXlnfx4mtT4insV9emHieBp+DdW?=
 =?us-ascii?Q?XaVxZ1vBsYY4E63tpmNVHsgdTtMHYesVPwqOdQaLKZvx5ofqkyK21q69kYTs?=
 =?us-ascii?Q?DnM5wpuVm5QNGPcbR83Y1a/B6N7F4RU0nSQ0nU9ygDHnBOdtRVx7jhc9zw5L?=
 =?us-ascii?Q?hydW2Hm1/NjWuZ9XkE66CeFz/yqM7vDFtuKKNiBIAyVDV1LeoAt98ZLMkXAv?=
 =?us-ascii?Q?cAIPcUdC8OG3ah+wma74hPFgACVxyj3BDCTd3cvDt335LIYeVDP8LhQIAsDu?=
 =?us-ascii?Q?MBHHXUQQKLZVigA94In8NZdo+66Nck7NScJ0zQUowLqfCoTTs3sXRGrIzhbR?=
 =?us-ascii?Q?FxXfkvd/sxuAO9KnGQhmI4s0bVxX9p35s3UUGrIGyP/aUmtFNfcIrDAisEW/?=
 =?us-ascii?Q?OOG9KnxW7ePxhSAV+psZ3Ejuu+HL21ATMy2sTbBL12DxRu9kGWV6n07xuLrr?=
 =?us-ascii?Q?yBGSqLsj/J6oXhezcIO0fXYF1tmwCj6PGQbuI57Os09ONagvCiQCUi5hqG3Z?=
 =?us-ascii?Q?shRm/iHlr+h4alsG0Gn/4XwMC9tuWstLE0Wr6Vb7AmgwwsxI6Tw63iYPxLtg?=
 =?us-ascii?Q?r8fBf0PzhVlwM7YW4PmQAQGpu0En57sXYnuMKmlb2XrwLUrao960lZCBEzvz?=
 =?us-ascii?Q?4kfgMvGXp/TgXg8XPjE+FYQ7zkkX/cm+sZlWJur9SSfnjo87c90qXLr3k9tD?=
 =?us-ascii?Q?7+mNiJUlqOW+5y3Xn1XdiWXDNofmzLhUz+z9UpbgjhkuybtW8vnyHMF5v27V?=
 =?us-ascii?Q?OR/dPGDcbVL9S7DliG7eUHeRRY5TZz8wg07zXpquWyTqK3I62ledNHTTmXzw?=
 =?us-ascii?Q?OYbOsiQlK8TvVSo98/Ts0V/Lnj54pDe0AjnJhCqZG7ZDjPByyeFMZ/eoAVBT?=
 =?us-ascii?Q?jsewOvaZ5NUt08dvg7Xk9oFvOg3eQbsSZcMtJTToRi0/oNSlGot3BB4RnJya?=
 =?us-ascii?Q?QjvcFi0hzpgFNZfD8dh6qx4U7WOQPsu6jC/3YxgyhIzpg06ZLaMIPBVW81wT?=
 =?us-ascii?Q?HlyrQRaocFpsntHyVF2gg9ZlTagGGJLa++BDZfGOMd326JYfK45AVuHUUn28?=
 =?us-ascii?Q?vhx62DZ4v4Dbt1jbsufyCiTUISaaN2v+hWeCfl5hq42VyfMQuPsuf2OA37AO?=
 =?us-ascii?Q?uMxDou5IcIMoOUgBs+CuXeJAnlgZQTW9fJQjMmZMOI8EIOu9MeVGoh3e/GGk?=
 =?us-ascii?Q?zm2Z3wzR0PyJ/14MPj2vOdettjw/VKfRM1LmUvk25cMtH+nI3jTD96PWJE0D?=
 =?us-ascii?Q?VjIgTqLAS+koTd4cKdAqHcm12oH+O6sm1bI1yymnEcvdWCHJwJPA6LFILyU+?=
 =?us-ascii?Q?J82kin68PTcp9JyE1B8PxFbyuP4h7/U+IJG5gQx7ApEncHgnJHh3FlyTBK34?=
 =?us-ascii?Q?TTCf7qKdWCnCfIRZSV0FjhJAu4+KU7bYx96nSD51PfqC0YFey/NOyw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4adc1f6e-867f-4efe-4681-08da06923387
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8477.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 14:43:43.0517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Smcucb1YRcFgyjWl+LVIVzzeZ4GYtMYZbWIsnMJRlxks83oH/UJg04zAxobW3NwTuBVdBLYFRhcgMfABOdE9Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7281
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When there're multiple process allocing dma memory in parallel
by calling dma_alloc_coherent(), it may fail sometimes as follows:

Error log:
cma: cma_alloc: linux,cma: alloc failed, req-size: 148 pages, ret: -16
cma: number of available pages:
3@125+20@172+12@236+4@380+32@736+17@2287+23@2473+20@36076+99@40477+108@40852+44@41108+20@41196+108@41364+108@41620+
108@42900+108@43156+483@44061+1763@45341+1440@47712+20@49324+20@49388+5076@49452+2304@55040+35@58141+20@58220+20@58284+
7188@58348+84@66220+7276@66452+227@74525+6371@75549=> 33161 free of 81920 total pages

When issue happened, we saw there were still 33161 pages (129M) free CMA
memory and a lot available free slots for 148 pages in CMA bitmap that we
want to allocate.

If dumping memory info, we found that there was also ~342M normal memory,
but only 1352K CMA memory left in buddy system while a lot of pageblocks
were isolated.

Memory info log:
Normal free:351096kB min:30000kB low:37500kB high:45000kB reserved_highatomic:0KB
	    active_anon:98060kB inactive_anon:98948kB active_file:60864kB inactive_file:31776kB
	    unevictable:0kB writepending:0kB present:1048576kB managed:1018328kB mlocked:0kB
	    bounce:0kB free_pcp:220kB local_pcp:192kB free_cma:1352kB lowmem_reserve[]: 0 0 0
Normal: 78*4kB (UECI) 1772*8kB (UMECI) 1335*16kB (UMECI) 360*32kB (UMECI) 65*64kB (UMCI)
	36*128kB (UMECI) 16*256kB (UMCI) 6*512kB (EI) 8*1024kB (UEI) 4*2048kB (MI) 8*4096kB (EI)
	8*8192kB (UI) 3*16384kB (EI) 8*32768kB (M) = 489288kB

The root cause of this issue is that since commit a4efc174b382
("mm/cma.c: remove redundant cma_mutex lock"), CMA supports concurrent
memory allocation. It's possible that the memory range process A trying
to alloc has already been isolated by the allocation of process B during
memory migration.

The problem here is that the memory range isolated during one allocation
by start_isolate_page_range() could be much bigger than the real size we
want to alloc due to the range is aligned to MAX_ORDER_NR_PAGES.

Taking an ARMv7 platform with 1G memory as an example, when MAX_ORDER_NR_PAGES
is big (e.g. 32M with max_order 14) and CMA memory is relatively small
(e.g. 128M), there're only 4 MAX_ORDER slot, then it's very easy that
all CMA memory may have already been isolated by other processes when
one trying to allocate memory using dma_alloc_coherent().
Since current CMA code will only scan one time of whole available CMA
memory, then dma_alloc_coherent() may easy fail due to contention with
other processes.

This patch introduces a retry mechanism to rescan CMA bitmap for -EBUSY
error in case the target memory range may has been temporarily isolated
by others and released later.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
CC: stable@vger.kernel.org # 5.11+
Fixes: a4efc174b382 ("mm/cma.c: remove redundant cma_mutex lock")
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
ChangeLog:
 * v2->v3: Improve commit messages
 * v1->v2: no changes
---
 mm/cma.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/mm/cma.c b/mm/cma.c
index eaa4b5c920a2..46a9fd9f92c4 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -430,6 +430,7 @@ struct page *cma_alloc(struct cma *cma, unsigned long count,
 	unsigned long i;
 	struct page *page = NULL;
 	int ret = -ENOMEM;
+	int loop = 0;
 
 	if (!cma || !cma->count || !cma->bitmap)
 		goto out;
@@ -457,6 +458,16 @@ struct page *cma_alloc(struct cma *cma, unsigned long count,
 				offset);
 		if (bitmap_no >= bitmap_maxno) {
 			spin_unlock_irq(&cma->lock);
+			pr_debug("%s(): alloc fail, retry loop %d\n", __func__, loop++);
+			/*
+			 * rescan as others may finish the memory migration
+			 * and quit if no available CMA memory found finally
+			 */
+			if (start) {
+				schedule();
+				start = 0;
+				continue;
+			}
 			break;
 		}
 		bitmap_set(cma->bitmap, bitmap_no, bitmap_count);
-- 
2.25.1