Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220315091319.3351522-1-daniel@0x0f.com> <s5h8rtba4to.wl-tiwai@suse.de>
 <PAXPR10MB47185B76D5F38482FB1125A5F1109@PAXPR10MB4718.EURPRD10.PROD.OUTLOOK.COM>
In-Reply-To: <PAXPR10MB47185B76D5F38482FB1125A5F1109@PAXPR10MB4718.EURPRD10.PROD.OUTLOOK.COM>
From:   Daniel Palmer <daniel@0x0f.com>
Date:   Tue, 15 Mar 2022 22:26:41 +0900
Message-ID: <CAFr9PXn=vRV4Jvxc+w9XJiAB8eAzq9MUfu+frMkS1P83Vp2Ujw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: sti: sti_uniperif: Remove driver
To:     Arnaud POULIQUEN <arnaud.pouliquen@st.com>
Cc:     Takashi Iwai <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Arnaud,

On Tue, 15 Mar 2022 at 22:15, Arnaud POULIQUEN <arnaud.pouliquen@st.com> wrote:
> > Yeah, that looks dead.
> >
>
> The platform is still used for instance:
> https://lore.kernel.org/all/1d95209f-9cb4-47a3-2696-7a93df7cdc05@foss.st.com/
>
> So please do not remove the driver
>
> The issue has not been detected because it is related to an error that
> occurs only when we reach the limit of the platform, with application
> that stop the stream at same time.
> So almost no chance to occur.
>
> > OTOH, if anyone really wants to keep the stuff, please revert the
> > commit dc865fb9e7c2251c9585ff6a7bf185d499db13e4.
>
> Yes reverting the commit is one solution.
> The other is to clean-up the snd_pcm_stream_lock/ snd_pcm_stream_unlock in the
> Handler.
>
> I will try to address this in few weeks

Feel free to ignore my patch then. I couldn't find anything that used
it's DT compatible etc and assumed it was orphaned.

Cheers,

Daniel