Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f2cafaa-e1f3-7f75-10a5-b8edb6de26d7@csgroup.eu>
Date:   Tue, 15 Mar 2022 10:42:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH -next] powerpc/eeh: Add correct inline functions
Content-Language: fr-FR
To:     YueHaibing <yuehaibing@huawei.com>, ruscur@russell.cc,
        oohall@gmail.com, mpe@ellerman.id.au, benh@kernel.crashing.org,
        paulus@samba.org, sbobroff@linux.ibm.com
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
References: <20210331125313.24036-1-yuehaibing@huawei.com>
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
In-Reply-To: <20210331125313.24036-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 31/03/2021 à 14:53, YueHaibing a écrit :
> pseries_eeh_add_device_early()/pseries_eeh_add_device_tree_early() is
> never used since adding, however pseries_eeh_init_edev() and
> pseries_eeh_init_edev_recursive() need their inline versions.
> 
> Fixes: b6eebb093cad ("powerpc/eeh: Make early EEH init pseries specific")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Those inline are not needed at all:
- pseries_eeh_init_edev_recursive() is only called from files build wich 
CONFIG_HOTPLUG_PCI_RPA which depends on CONFIG_PSERIES and CONFIG_EEH
- pseries_eeh_init_edev() is used exclusively in
arch/powerpc/platforms/pseries/eeh_pseries.c and should be made static.

Can you update your patch ?

Thanks
Christophe

> ---
>   arch/powerpc/include/asm/eeh.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> index b1a5bba2e0b9..0b6c2a6711d3 100644
> --- a/arch/powerpc/include/asm/eeh.h
> +++ b/arch/powerpc/include/asm/eeh.h
> @@ -357,8 +357,8 @@ static inline int eeh_phb_pe_create(struct pci_controller *phb) { return 0; }
>   void pseries_eeh_init_edev(struct pci_dn *pdn);
>   void pseries_eeh_init_edev_recursive(struct pci_dn *pdn);
>   #else
> -static inline void pseries_eeh_add_device_early(struct pci_dn *pdn) { }
> -static inline void pseries_eeh_add_device_tree_early(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev(struct pci_dn *pdn) { }
> +static inline void pseries_eeh_init_edev_recursive(struct pci_dn *pdn) { }
>   #endif
>   
>   #ifdef CONFIG_PPC64