Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b28a6f3-8d3d-76f4-d517-62260ac5b337@intel.com>
Date:   Mon, 14 Mar 2022 14:05:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Content-Language: en-US
To:     Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
        catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220311101940.3403607-1-tarumizu.kohei@fujitsu.com>
 <20220311101940.3403607-7-tarumizu.kohei@fujitsu.com>
From:   Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v2 6/8] x86: Add hardware prefetch control support for x86
In-Reply-To: <20220311101940.3403607-7-tarumizu.kohei@fujitsu.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/11/22 02:19, Kohei Tarumizu wrote:
> +static int broadwell_write_pfreg(enum pfctl_attr pattr, unsigned int cpu,
> +				 unsigned int level, u64 val)
> +{
> +	int ret;
> +	u64 reg;
> +
> +	ret = rdmsrl_on_cpu(cpu, MSR_MISC_FEATURE_CONTROL, &reg);
> +	if (ret)
> +		return ret;
> +
> +	ret = broadwell_modify_pfreg(pattr, &reg, level, val);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = wrmsrl_on_cpu(cpu, MSR_MISC_FEATURE_CONTROL, reg);
> +	if (ret)
> +		return ret;
> +
> +	return 0;
> +}

This needs to integrate _somehow_ with the pseudo_lock.c code.  Right
now, I suspect that code would just overwrite any MSR changes made by
this code.