Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp4370249pxp; Tue, 15 Mar 2022 19:52:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdqx2ki9qK1fAKfIHsns5ZaoTBXvYLZkOWQ4IZCY3ZOWRt0ZdrvpyqiZQDmzSxLMY4c5nq X-Received: by 2002:a17:90b:4c0d:b0:1c6:2dc4:3cf with SMTP id na13-20020a17090b4c0d00b001c62dc403cfmr7957945pjb.208.1647399126661; Tue, 15 Mar 2022 19:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647399126; cv=none; d=google.com; s=arc-20160816; b=CTzxWIFe8oyF63WUXugLyLzwSCVBlneT3rkaIp4CGrl8EWtN8bDSBCS+A2KZc8UKk0 m+OMRXiYs+Kd4weujA1nURNRJ3OjF5/ko4FEx0vvK9a39+4mBKaUV9NuwBPZliHrt1Vb qHDQ0b+UKqvj0zzLh27WxwrMRsHM7B3INWkMRLZWFsq4q06gQ5T2pLuwvf7V0ijgaki7 5ZJg3V37xW/sEw1px2/cEXFEfT1MPKadP8WjRfstZb2/47JielngzbOTyvH8sgC6O4Cd +/GxISw2CPgo0XvXQhYf2I5xX1cT/ddpBf3vZsZBpsWpNs8wVl3G1pe/Ht35YlbUColQ H+5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MqLppnGP4MbsD+gVviOPlH5VnfiPJBlj6/pZOIVk87s=; b=R4rz1qqrZSC4oH6ElQjmCaIoAfi1nn6SlobDJPHc+okSUfAnZ11KvsSN7xFP91NPrR uu0xemWY97OfEmpreFRbV3qI9WPGzxfVoWosGzmBbi6t6Nr6BrlA1zN9e43OrsBR4lvq 4gUwzdJirdHg5pcCVOYHPLr21khmAbCRs2gxSgKtjzneAxEcpO9l+Cg5IoEJyhFZkQpi Ah7IbSh+NpZ1TImj+TEKfJqX4lLCFXS0eB5Y/5tB/FyuMJNI9sGJMB17haIjBpo+4ukV h0HhovVDIS4znAMS/o9et/JhcYJPNAKePewmlHQdIr/eeBn7YToGIO/Zju4qo631JWUa tw4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dMTpOfPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j18-20020a63ec12000000b003736dfb029asi794436pgh.449.2022.03.15.19.51.52; Tue, 15 Mar 2022 19:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dMTpOfPN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238959AbiCOAXP (ORCPT + 99 others); Mon, 14 Mar 2022 20:23:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230466AbiCOAXO (ORCPT ); Mon, 14 Mar 2022 20:23:14 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7F1C3F316 for ; Mon, 14 Mar 2022 17:22:03 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-2dbd8777564so184710377b3.0 for ; Mon, 14 Mar 2022 17:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MqLppnGP4MbsD+gVviOPlH5VnfiPJBlj6/pZOIVk87s=; b=dMTpOfPNcuKpTGl/JROG/JfBp6BpRXuCPI7gXdwwNZxgiZQqpugLMPeFDPkXwYOwwq zDFEZFGTMp/wQ6s/n41FvqOf+fP7hCh+PVZEB2t7yvJsx1Py+mmYIE3wkIB97ru3nxnX 8iYD+r3adI3DiwmFOBL2Krua262HaeWj9bFF2ITuaoCFESlH8e+0u021wuDwaqlzgUSK jvHFShoXHwMlO5Ztbj0woLMnJxFlzb/0lNljSP375mC4gS/Vh18qtVTL6Z1NbHDOIMTl rVEeLLIPlcXdPbpCF95OoYCr0MzRoZ2hGVrKMN1+s+RaFT6lYYoPrqTrDtuaxMzCeV8H 6Amg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MqLppnGP4MbsD+gVviOPlH5VnfiPJBlj6/pZOIVk87s=; b=PQ21dxFJfdSA5WVlL5H5AKW9NVazTocWoiBNQu/TdeNvq7krxjKksk3E4sUQjAVsCE ms1RTEreqYQNPPavSy8sZyA25X+MBVlHrK7u8cmfMuL/1lV0znN14Toz5rTJBhZri6PU 8vHnn/y9HDbP/9Tu3wvkZIrGdEoG++FyXhKpXbV4sYzfvZX7Fxin3RIQStPT/zYue9z7 xJJ0Pg3nFa0Zzs8jwRbJU0hMePW3kyELDGUF7ZuGCpytuYMq9a+gf47qxl978ZICFKX0 uixZ3+Gc61NNnwPrx67Ximug1LhHEgC0/d3Ynb6wfNDwA/IsQb/CsNalX8YTBNVYiBck fvKg== X-Gm-Message-State: AOAM532MgYh6c0dLD6ZDp5gk0rtiYfW2VhZORhSEmN3RqGOHwO8BRK/O H2fw5EaVQsRiE/x4A3zrNYP1fnmivruGV56vvTD1uUfBpXk= X-Received: by 2002:a81:89c2:0:b0:2e5:84b7:83e with SMTP id z185-20020a8189c2000000b002e584b7083emr1458669ywf.448.1647303723144; Mon, 14 Mar 2022 17:22:03 -0700 (PDT) MIME-Version: 1.0 References: <20220308071155.21114-1-linmq006@gmail.com> In-Reply-To: <20220308071155.21114-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 15 Mar 2022 01:21:52 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init To: Miaoqian Lin Cc: Sean Wang , Matthias Brugger , Hongzhou Yang , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 8, 2022 at 8:12 AM Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Fixes: a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.") > Signed-off-by: Miaoqian Lin Patch applied. Yours, Linus Walleij