Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Wenchao Hao <haowenchao@huawei.com>
Cc:     Mike Christie <michael.christie@oracle.com>,
        Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        <open-iscsi@googlegroups.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Wu Bo <wubo40@huawei.com>,
        Zhiqiang Liu <liuzhiqiang26@huawei.com>,
        <linfeilong@huawei.com>
Subject: Re: [PATCH v3 0/3] scsi:iscsi: handle iscsi_cls_conn device with
 sysfs correctly
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1bky7dexf.fsf@ca-mkp.ca.oracle.com>
References: <20220310015759.3296841-1-haowenchao@huawei.com>
Date:   Tue, 15 Mar 2022 00:21:11 -0400
In-Reply-To: <20220310015759.3296841-1-haowenchao@huawei.com> (Wenchao Hao's
        message of "Wed, 9 Mar 2022 20:57:56 -0500")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IAuUl2osm+0ivgabXbF64mu5wWpJTzyq+d4exCIsrAjMmsHC1cWz4B4X+qIK?=
 =?us-ascii?Q?6MoL5Rp5r280lUfkHJtrJZfoJ1Me+/8fKRkPP//pwWu//wi7flNf5zVcalAp?=
 =?us-ascii?Q?SqCJRDWN64DPRI1S0beoMMtqOAWqhhJJqToIW/kQ/WKduftxc8vdKbFUGPRa?=
 =?us-ascii?Q?SCqPFhWvyKMSqiOn48O6HAKtZ8EzUeIlqYx97WhdvvYz/2V2FpRZHN75An/K?=
 =?us-ascii?Q?+eTuDjvhz5sB8nP+dkhj800UM8Yx3lF7da7fcRj3AtHm1eh+Br4cQ3rlJOtq?=
 =?us-ascii?Q?dxEDajp5mJxU8HbTqRyPjz5wRSu+AGpsROasDQn8J8TxdwOXbOC9O/d7YCHP?=
 =?us-ascii?Q?LCQWfU8whOuNZGkt6hENLq0ufJvJ0jzRzQDs9IrthjN0N1/62EZBYinoa7er?=
 =?us-ascii?Q?+Q7xEIfwcj8jOFg2FiDdWRatRBhrf76sGwCzUoEoFKcchgJhNSIo3mij4wjh?=
 =?us-ascii?Q?haDCMMOokMjIZWcWoeiybXxDpyE6ebq6Q5kD9DYW83N2h6skixlePTBYpEyI?=
 =?us-ascii?Q?P+7x8ns/T5DflwVqrc53OEF+wsaY0ZdF0HG3ENDQxJRr/CO4DaaNHRkEs0KY?=
 =?us-ascii?Q?2rhR4AHGn6RRgZR12ywZcHqXqdLGgvEen9AHeEiDX1G6vttdcMrU2Kz88pxO?=
 =?us-ascii?Q?Mz6oKkUIKOY8JMVL3pyQP0Bq9+nd6FF1CqR0y84+rUldCZ3Lw42FulejF3c3?=
 =?us-ascii?Q?sY9YF5dsirE07eEl6zijkNdCxvmg6CobYvU3AnXLl4sIJBYd1U+79+vT4wz4?=
 =?us-ascii?Q?XaOV5INEdagAL++JYu5a2ckLvqGrTs9YeRfbiqRBd2Z0Fzhe36oOO3kTCaia?=
 =?us-ascii?Q?qkcXmKEfJ0pTsrstpEvKJv8HnQHR6Uij6tcLYGbSE0Pxoroc65/NEFk6NjS5?=
 =?us-ascii?Q?g9669TY+/ujH2XSQMgSL22CpIKdVIEyHfJMlZnXgAECIwouyObcJ9P+8gk2H?=
 =?us-ascii?Q?IKXUIiuN4VYuvuM+VW+Xd/NL4mQCtDHmjMGc597WfhwRKxcCNDhn6Z5XpJN2?=
 =?us-ascii?Q?tyYYa2Zktkk5OK7Rn+b0fnoBW5bds5pdJ3vSNND5433wzljVBAUVDNLDsmWw?=
 =?us-ascii?Q?BiNVVwmyQWU4FOlfgQ1Dnj5mW9JYgo02k8ecTBPQBbkHEeNNx54UK9HNt5Fx?=
 =?us-ascii?Q?Zl7v3CyctLv0GEYJeDf9gehdZzwI/U5N6NyXoG5I9PQmaGoJKcmjWO2vy/6C?=
 =?us-ascii?Q?h2GqlIpuueMANxI1wIExMoB9cb8B/IdaeucbXOkdmXXXuY+f3bxQme0rrrOO?=
 =?us-ascii?Q?cPOBTFgh2NJevlUzd2Wpzc2/7NklxDwa8BbrYFubqKJRUQ2pGpADmNI8rpI8?=
 =?us-ascii?Q?M8QeZZDob54iDqN4gDdnkIxNC8IAKXdD4HXHoonfEbxtTC/CWmUCV6wbzSjM?=
 =?us-ascii?Q?/9dPSVc6QF/iweIIHyD4T+UjXbwyf830AQlztHOTRyEigLZRYSQUR8V5mhJ6?=
 =?us-ascii?Q?pjA3ODo+LMTSPwEkQ6kK0N8vWqS5rxJC/NcUcO+SHvUtNTJC8iJCXg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73533df6-555c-434b-1a92-08da063b3da4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2022 04:21:13.4441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NEExHLrMOXSnMcwS6DgxlUEilyEtc98FGyVNPdrXtgMjjarpSUKfQXa+kvmOFTfpIZSG6cxmfXGGWIdZzwymj/8a0g6P+ClZstcAtU3ZQtk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4457
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10286 signatures=693139
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=604
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203150026
X-Proofpoint-GUID: 9NezOOlrLRAO4y65L6504En3FzBFe6Sj
X-Proofpoint-ORIG-GUID: 9NezOOlrLRAO4y65L6504En3FzBFe6Sj
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Wenchao,

> We found a NULL pointer dereference in iscsi_sw_tcp_conn_get_param(),
> the root reason is we did sysfs addition wrong.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering