Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Mar 2022 13:46:01 +0100
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     Jonathan McDowell <noodles@earth.li>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Taniya Das <tdas@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 15/15] ARM: dts: qcom: add syscon and cxo/pxo clock to
 gcc node for ipq8064
Message-ID: <Yi85CWQdY08GLxzp@Ansuel-xps.localdomain>
References: <20220226135235.10051-1-ansuelsmth@gmail.com>
 <20220226135235.10051-16-ansuelsmth@gmail.com>
 <Yi8SrZkjYdU3W8aj@earth.li>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yi8SrZkjYdU3W8aj@earth.li>
Precedence: bulk

On Mon, Mar 14, 2022 at 10:02:21AM +0000, Jonathan McDowell wrote:
> AFAICT the rest of the series has been picked up in clk-for-5.18, but I
> don't see this there or in dts-for-5.18. It's required for a
> functioning tsens driver on IPQ8064 so it would be nice to see it landed.
>

I think we just have to wait, they said that it was expected a delay
between the clk and the dts merge. (one of the reason I couldn't drop
the pxo/cxo fixed clock)

> On Sat, Feb 26, 2022 at 02:52:35PM +0100, Ansuel Smith wrote:
> > Add syscon compatible required for tsens driver to correctly probe driver
> > and access the reg. Also add cxo and pxo tag and declare them as gcc clock
> > now requires them for the ipq8064 gcc driver that has now been modernized.
> > 
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> > ---
> >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 11481313bdb6..5524a68cf3d1 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -298,13 +298,13 @@ smem: smem@41000000 {
> >  	};
> >  
> >  	clocks {
> > -		cxo_board {
> > +		cxo_board: cxo_board {
> >  			compatible = "fixed-clock";
> >  			#clock-cells = <0>;
> >  			clock-frequency = <25000000>;
> >  		};
> >  
> > -		pxo_board {
> > +		pxo_board: pxo_board {
> >  			compatible = "fixed-clock";
> >  			#clock-cells = <0>;
> >  			clock-frequency = <25000000>;
> > @@ -736,7 +736,9 @@ tsens_calib_backup: calib_backup@410 {
> >  		};
> >  
> >  		gcc: clock-controller@900000 {
> > -			compatible = "qcom,gcc-ipq8064";
> > +			compatible = "qcom,gcc-ipq8064", "syscon";
> > +			clocks = <&pxo_board>, <&cxo_board>;
> > +			clock-names = "pxo", "cxo";
> >  			reg = <0x00900000 0x4000>;
> >  			#clock-cells = <1>;
> >  			#reset-cells = <1>;
> > -- 
> > 2.34.1
> > 
> 
> J.
> 
> -- 
>     I program, therefore I am.     |  .''`.  Debian GNU/Linux Developer
>                                    | : :' :  Happy to accept PGP signed
>                                    | `. `'   or encrypted mail - RSA
>                                    |   `-    key on the keyservers.

-- 
	Ansuel