Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp434938pxp; Wed, 16 Mar 2022 08:41:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwW2FomeAz7Vwvd1v4nRLXijNWx1iN7OzBdT3p4n2YNYiv3LEicn492SfAz6oeo1fH1Q5B7 X-Received: by 2002:a17:907:8a0c:b0:6df:8b04:1a65 with SMTP id sc12-20020a1709078a0c00b006df8b041a65mr230006ejc.331.1647445281943; Wed, 16 Mar 2022 08:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647445281; cv=none; d=google.com; s=arc-20160816; b=UGS3qk+h6v5e/lzr2NFMJUFLv97fYOvpQRLd/BHW5sh4aNz4D8fxXcab2c6UrqrpLh omGj4kyxfq6jCZh1huh1pP6NwVEqnhr31TQ2YMdVciIflvwqQ+fBago8J3z8Bc5mZMUs agLbTyel9Rh5Uwx54nH7SnMt3OsXRotX1RbGBvKTSo8ucMmucUD/DWPIx/I8048BHzmO IfSjy3wNzCo1pp8k02nAVNRnS/hkBC3szLFGbCrRg8/Yh5ssbGGM84q4gJN7lgdLQiHR oK55zmmCf9tSYgL1slvGkDMeSJzDEjZjwEHzdiUernXsKPXXkGMReNm/o/fopKIoti15 /a1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1vA00ex1vedjXJAl0s4uApsJ3ZLM2nW9g6K2ecOh3T8=; b=LvqiLRgUTp8WnsbNodMULV5VKT46GBcfcdN4t2fS8zm///pxY/iibm3bDrakttVZSC uJyjCNbau7ovjPLUzZtCjh0GBD+Mtlh3JNYkmTv+zdzud4vYG2UkMV7TPXzjzit1kHDm PymRJ8MXQvI+sKhm5zWxMsK3rJSOvNMyiJ0KduLoMzFFq9szyKYFqY//mFlaHunTFLOW RTKsgJUOetoEVyzNX6NeqUYu90luW5gaNhYZcVa+mzt01xgSlD6DX76CmQlDg98RW+Ok mSZzRcqo8KoA0WjbdFQsRBoH1p/dgy62IyJW3xcrpqvF16JmO2XLkw0DzSMsfON2WLpY SNWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GjVi5pYN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a05640227cc00b0041649af58a7si1772124ede.19.2022.03.16.08.40.52; Wed, 16 Mar 2022 08:41:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GjVi5pYN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350858AbiCOSQa (ORCPT + 99 others); Tue, 15 Mar 2022 14:16:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237705AbiCOSQ3 (ORCPT ); Tue, 15 Mar 2022 14:16:29 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A83C710FD9; Tue, 15 Mar 2022 11:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647368117; x=1678904117; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cBl7++E0lyz16jxeiMNZ6a6aEo5QRd5rFAMudPSZAW0=; b=GjVi5pYN0/794iHUoba777cmlJ+Z4B0U43pAe654Zfq6hUpGE4+0UM37 F0OunZLN1TAi/qIu9Q9bKsvl3jCBlMh+ByyQlKwiZMeLcYLklzJzbr8YY 7vkT/23JWOgINvZZiGYidWBvJ5lvIt0K66KXTa15btu9xYoR9tha+4eHh 6kzyVVALgGo0bTlwq7HlP7D6rdEV85vkmkaH/qIYdfHucPpgY/2kIaFht tnYgGYCk3FFYUF+Je3zNYESHJE+RKSiEtq2+YCVegfeLVGTFKWRoWdBl0 iVOF2n8MopvisszQgO6ECJxSl0nLt88hHITRJhuUKr+0ePphUMCN1VTVZ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256583264" X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="256583264" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 11:15:16 -0700 X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="512713792" Received: from agluck-desk3.sc.intel.com ([172.25.222.60]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 11:15:16 -0700 From: Tony Luck To: Borislav Petkov Cc: Smita Koralahalli , hpa@zytor.com, Dave Hansen , Yazen Ghannam , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v2 0/2] New CMCI storm mitigation for Intel CPUs Date: Tue, 15 Mar 2022 11:15:07 -0700 Message-Id: <20220315181509.351704-1-tony.luck@intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Two-part motivation: 1) Disabling CMCI globally is an overly big hammer 2) Intel signals some UNCORRECTED errors using CMCI (yes, turns out that was a poorly chosen name given the later evolution of the architecture). Since we don't want to miss those, the proposed storm code just bumps the threshold to (almost) maximum to mitigate, but not eliminate the storm. Note that the threshold only applies to corrected errors. Patch 1 deletes the parts of the old storm code that are no longer needed. Patch 2 adds the new per-bank mitigation. Smita: Unless Boris finds a some more stuff for me to fix, this version will be a better starting point to merge with your changes. Changes since v1 (based on feedback from Boris) - Spelling fixes in commit message - Many more comments explaining what is going on - Change name of function that does tracking - Change names for #defines for storm BEGIN/END - #define for high threshold in decimal, not hex Tony Luck (2): x86/mce: Remove old CMCI storm mitigation code x86/mce: Add per-bank CMCI storm mitigation arch/x86/kernel/cpu/mce/core.c | 46 +++--- arch/x86/kernel/cpu/mce/intel.c | 241 ++++++++++++++--------------- arch/x86/kernel/cpu/mce/internal.h | 10 +- 3 files changed, 141 insertions(+), 156 deletions(-) base-commit: ffb217a13a2eaf6d5bd974fc83036a53ca69f1e2 -- 2.35.1