Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp468391pxp; Wed, 16 Mar 2022 09:18:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypc1lGrdApbYWDt9AP1aIzpyVy8E3AXfEx7CvYkHzpxDlwKGnwxT6IB+3/ly+gOI+1gBdT X-Received: by 2002:a17:906:4313:b0:6b8:b3e5:a46 with SMTP id j19-20020a170906431300b006b8b3e50a46mr588554ejm.417.1647447498545; Wed, 16 Mar 2022 09:18:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647447498; cv=none; d=google.com; s=arc-20160816; b=sHLK36m3QcnCxjekuI5ycsK5OQNPYXdFjq80lTOT27F+WoIDAzytX00PEEAvOmkyuj OITcx8ijsCIpzNwpdSBD1+p3UFFdj02OadqYbNV0jgfYQnu56mi8OnObAlOHHyijqGhL 64pA7j9FD9Ctb1Hckdba0E/1E6Hbyu0hQlKyXlWxYWs/FaQzPLZGON0I7GnrN8HSDCVe wU3GvS1nH63sHOW5+rd7ocJtdD6yyh7TwL63RjeTPKv1yFUnMbabVz5asXFLMU3xH+LG dnwkDCgvp38Me8fdtVphDFbFqfwlOpsHezqrTud3J5FtE8+FMLxR33hO8FVkJYp4ahpU WYPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Mf/dZT0qRm4Kxug1Ehx9O+x4uElpkG25PNAlHiqytoA=; b=DaZaAPx8CTWBoKMNfgWAHs93eVmcnxtRjYx2S1JEkocDCJ1PUJSdUGIl645gTk6aYT CdduUH6Rga7Gn+4rmX3ZU8YU/UzIf+VOM7frDfDsWtk8Xapuine2T6VVBxPi2/SG5BVB Rpw4d6T61j8OJ44GgF88k/XrNYPYifdDb3huS6wB/utpz/yXMrxWagUDFfIaWOs2YZKL UBtjJqnbEYAOOzT1elJuo8R1ED+g/j6GiPdzj2Wl11JKcOByp9sfGFCdIjQoh5NAAGgw tU/HnZ50h+rHrJuj0bQgeW5OnO9BTwsczgmRX229feO32MXLgEcU61FejCtDWKo9x7hA Im+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QANKskSr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u4-20020a50c044000000b00418d5f795bcsi1502515edd.399.2022.03.16.09.17.52; Wed, 16 Mar 2022 09:18:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QANKskSr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242510AbiCNMTH (ORCPT + 99 others); Mon, 14 Mar 2022 08:19:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242494AbiCNMKE (ORCPT ); Mon, 14 Mar 2022 08:10:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A13A622BCA; Mon, 14 Mar 2022 05:08:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 80CB561314; Mon, 14 Mar 2022 12:08:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D2E2C340E9; Mon, 14 Mar 2022 12:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647259717; bh=JNgz7aOmQOURe9AXh8w879yMAAPClIIjiSnyCIm1RY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QANKskSrQqm9vVqO2l2VoOOycUcMCqXDfr2010HTyEMhGQRwqBNLQ41+sR9hbaApX 92guk6HQt0wgIHt7rM00+jTeXd7Xe/VBO7NXQ5ZRwvFoBScvxCv1Th2FIfJz4u8q1q TxB5PrMfZfw9weTagscnmz2Xx3FIiYZQCzGZMkKA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jiasheng Jiang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.15 036/110] net: ethernet: ti: cpts: Handle error for clk_enable Date: Mon, 14 Mar 2022 12:53:38 +0100 Message-Id: <20220314112744.045684399@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112743.029192918@linuxfoundation.org> References: <20220314112743.029192918@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiasheng Jiang [ Upstream commit 6babfc6e6fab068018c36e8f6605184b8c0b349d ] As the potential failure of the clk_enable(), it should be better to check it and return error if fails. Fixes: 8a2c9a5ab4b9 ("net: ethernet: ti: cpts: rework initialization/deinitialization") Signed-off-by: Jiasheng Jiang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ti/cpts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c index 43222a34cba0..f9514518700e 100644 --- a/drivers/net/ethernet/ti/cpts.c +++ b/drivers/net/ethernet/ti/cpts.c @@ -568,7 +568,9 @@ int cpts_register(struct cpts *cpts) for (i = 0; i < CPTS_MAX_EVENTS; i++) list_add(&cpts->pool_data[i].list, &cpts->pool); - clk_enable(cpts->refclk); + err = clk_enable(cpts->refclk); + if (err) + return err; cpts_write32(cpts, CPTS_EN, control); cpts_write32(cpts, TS_PEND_EN, int_enable); -- 2.34.1