Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHk-=wiHa0vsZseZES=1T0rJ4Z_bC5cwHMUJfqFL9hVpvB283g@mail.gmail.com>
 <20220314192522.GA3031157@roeck-us.net>
In-Reply-To: <20220314192522.GA3031157@roeck-us.net>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 14 Mar 2022 13:13:59 -0700
Message-ID: <CAHk-=wiEhs+4P1TNh2sNnk04D1FFdNThk6XLOMxzkRL72PEXFw@mail.gmail.com>
Subject: Re: Linux 5.17-rc8
To:     Guenter Roeck <linux@roeck-us.net>,
        Thierry Reding <treding@nvidia.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Vidya Sagar <vidyas@nvidia.com>,
        Edmond Chung <edmondchung@google.com>,
        Andrew Chant <achant@google.com>,
        Will McVicker <willmcvicker@google.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

[ Adding more people to the cc, since this last change was triggered
by earlier changes.

On Mon, Mar 14, 2022 at 12:25 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> Build results:
>         total: 155 pass: 155 fail: 0
> Qemu test results:
>         total: 488 pass: 484 fail: 4

Uhhuh. We got all the previous problems sorted out, but a new one instead.

> This is a new problem. It bisects to commit fc328a7d1fcc ("gpio: Revert
> regression in sysfs-gpio (gpiolib.c)"). The network connection fails
> in the affected tests. Reverting the offending commit (ie reverting the
> revert) fixes the problem.

Hmm. Looking at the changes since 5.16, that commit fc328a7d1fcc looks
somewhat suspicious.

It claims to "revert" things, but the behavior it reverts goes
basically all the way back to v5.7 (with one of the patches going into
5.10).

And it clearly breaks things that used to work much more recently (ie
this worked in rc7, but it was also the state in every release since
5.10).

So unless somebody can find the _real_ issue here, I suspect very
strongly that that "fix" that came in last week was just wrong.

It is also very non-specific "Some GPIO lines have stopped working"
with no pointer to actual reports.

LinusW? Thierry? Bartoz? Anybody?

Yes, there;s something bad going on here, but we can't randomly "fix"
things in an rc8 that have worked for several releases by now.

               Linus