Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp533165pxp; Wed, 16 Mar 2022 10:39:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxe2i/eDf+LMiPcgCoOZWrbVsn3nq/3+sh3LH7EaoKk+DwOUzIlmBP2D1JUCoT5qEGXhIhj X-Received: by 2002:a17:902:e5c6:b0:153:c2e0:7222 with SMTP id u6-20020a170902e5c600b00153c2e07222mr774162plf.94.1647452347275; Wed, 16 Mar 2022 10:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647452347; cv=none; d=google.com; s=arc-20160816; b=QAUO7Sr704X+pswAO6yIlZjw5jGkybrxVfAKeCS/xDo/umfRCE5zbnd3PfZWEmZ9wi 7IOycJcI+kB1ylSaYycWulWMm+wIHqlSc74eocGY2Mk49Tg6XBuPXkYRvX6noEveYkyI HrQCeAlwhwvw501su3IJ/+dF34HR1K1NwdM6LyP9slI26fsP0cE/nL3bN2ZOglHyt1uK 1wY4yZQP7ApMOFMlOX0PfWpYodHcz4A4Xe8IfiWWIL+E5J6WJDHDwB5EmvnJRnTv3WjI jfkNqVbRzW08KYwz6Eo+DCWOVlV8RLyPQHgLKaEF5mMOaE8+f0V1u/FGoOJVGrCCVnCF pQqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=zjQd5ds1tB96QrNgKyLX/O3ok9o8ubHd9COQiQHivGs=; b=MisxqBE5oSHFs/LfXupQvUaHoxptjcZWJBMGHxstP+fXkeOixU53jS0DSISqCSg9JT p1MNNA2/hhmoN9m+K5cZ9R6KecqhbWra5GouED/bB6OnCyMokBg4QdEiZp7OIHhlpNNz AiMd7k3DeyGX6VXi7chMWY9JLrwvIJnP2An84o4kCxY6eJLME09oesl/IJaqiqRII9jm 0z/QdiPWE7baUz2P7JoQ60GcaETdRHvKTtc+50yJ9v1zdk5SFw5A7dL/BNkwrGdMq0Ip sV1Q8y3brNXUbcUuJwl02s39VlWNeaTSXsl3pFKGF9BQvaCV2eh8UWO7DtAoFPalwTON QqZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v124-20020a632f82000000b0038038109f54si2594216pgv.446.2022.03.16.10.38.52; Wed, 16 Mar 2022 10:39:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345864AbiCOI0N (ORCPT + 99 others); Tue, 15 Mar 2022 04:26:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243406AbiCOI0M (ORCPT ); Tue, 15 Mar 2022 04:26:12 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7323981F; Tue, 15 Mar 2022 01:25:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 08FED68AA6; Tue, 15 Mar 2022 09:24:57 +0100 (CET) Date: Tue, 15 Mar 2022 09:24:57 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Ondrej Zary , Damien Le Moal , Christoph Hellwig , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_parport: add driver (PARIDE replacement) Message-ID: <20220315082457.GB3502@lst.de> References: <20220312144415.20010-1-linux@zary.sk> <202203132015.18183.linux@zary.sk> <5161ed17-5f55-e851-c2e2-5340cc62fa3b@kernel.dk> <202203142125.40532.linux@zary.sk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2022 at 02:29:20PM -0600, Jens Axboe wrote: > The controller would set > > ->needs_blocking_queue_rq = true; > > or something, and we'd default to false. And if that is set, when the > blk-mq queue is created, then we'd set BLK_MQ_F_BLOCKING upon creation > if that flag is true. > > That's the block layer side. Then in libata you'd need to ensure that > you check that same setting and invoke ata_qc_issue() appropriately. > > Very top level stuff, there might be more things lurking below. But > you'll probably find them as you test this stuff... FYI, this somewhat mistitled series: https://lore.kernel.org/all/20220308003957.123312-1-michael.christie@oracle.com/ adds BLK_MQ_F_BLOCKING support to the scsi core. Doing libata should be fairly easy and can built ontop of that.