Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbXBVUs4 (ORCPT ); Thu, 22 Feb 2007 15:48:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751875AbXBVUs4 (ORCPT ); Thu, 22 Feb 2007 15:48:56 -0500 Received: from mail-gw2.sa.eol.hu ([212.108.200.109]:36408 "EHLO mail-gw2.sa.eol.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbXBVUsz (ORCPT ); Thu, 22 Feb 2007 15:48:55 -0500 To: staubach@redhat.com CC: miklos@szeredi.hu, akpm@linux-foundation.org, hugh@veritas.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-reply-to: <45DDF9C1.4090003@redhat.com> (message from Peter Staubach on Thu, 22 Feb 2007 15:14:57 -0500) Subject: Re: [PATCH] update ctime and mtime for mmaped write References: <20070221202615.a0a167f4.akpm@linux-foundation.org> <45DDD55F.4060106@redhat.com> <45DDF9C1.4090003@redhat.com> Message-Id: From: Miklos Szeredi Date: Thu, 22 Feb 2007 21:48:11 +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 34 > > __fput() will be called when there are no more references to 'file', > > then it will update the time if the flag is set. This applies to > > regular files as well as devices. > > > > > > I suspect that you will find that, for a block device, the wrong inode > gets updated. That's where the bd_inode_update_time() portion of my > proposed patch came from. How horrible :( I haven't noticed that part of the patch. But I don't think that's needed. Updating the times through the file pointer should be OK. You have this problem because you use the inode which comes from the blockdev pseudo-filesystem. > > > But I've moved the check from __fput to remove_vma() in the next > > revision of the patch, which would give slightly nicer semantics, and > > be equally conforming. > > This still does not address the situation where a file is 'permanently' > mmap'd, does it? So? If application doesn't do msync, then the file times won't be updated. That's allowed by the standard, and so portable applications will have to call msync. Thanks, Miklos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/