Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp597492pxp; Wed, 16 Mar 2022 12:08:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw99I5mzD05za7NZRtpmtjY57PoKcfD4Gtr7RxpAFUIKAq7+CJmD7yV3KgXED07X94o8qrF X-Received: by 2002:a17:906:c145:b0:6da:f8c8:34f1 with SMTP id dp5-20020a170906c14500b006daf8c834f1mr1156186ejc.310.1647457696018; Wed, 16 Mar 2022 12:08:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647457696; cv=none; d=google.com; s=arc-20160816; b=LhlqGV4XamrjqK2l8LqlN+uh9pQAT3mYlLWs8y8fP3yJDUQpCDKIZDiEjF93/crgdX d8zXnRhUE+5YRqchx1jBrR71c3EWme0SU75fbLiqVxybeAeqFIh2+GjQvEZ1cpUwQPhN 1UnKpF5YUBGjclMQkhOmHH8oQMgEsNnqserdkfAimH8bs35djZkSuPLzvxlmkE2i5PgB 2ULYtZRRysKNVs+0qS5JRoxl8kzkJ9Cyy4yeoAhfvagIVl0ZYnII9z+va3INxHgvJtuu RzkN0SKN0gJSlSEFKLhcy5A+xkCGxSOnE08ZIlwS2mvEkFjqAEwp1RQ1oSj6chxcKdzn DJNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Uj1acuBG5kcEqw59Y4tqrJax7+x9T6dt2CoxNkY2Fak=; b=VOgLEQ9v8hZAU4honT+dr7vyK+MX8Z/AJl1ft9KmpEILuahPyP+qlUHPYzL58llW/t TDGWdW8F6zURRHk5Pta5f1hSm2OQEX9/p5Zmt8HYg+RN6zkYDSjiR5fCEqKEWKqfMloD gxXBGuzSNoMz3Ad3itp2yUCwHdv/P+6kImLDa/GmMnL2fObl3ZndytajfWHKTckJ6zOn V5+Ml8nOvAg9k+6yI38OeoF/Lq7DVpLYDJu2NCXrKPN7+c25pYdUxUKZVD8vEFqC1Gfs e4M1+cv4MRFoUDRRTTizzFtk5uN2L3TiPJYHmSC7VDB3Me4bxh/vgWOgynMvLf/BeyJv UJVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=moVlMSHF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020aa7c311000000b004162725fbbdsi1847692edq.155.2022.03.16.12.07.49; Wed, 16 Mar 2022 12:08:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=moVlMSHF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345494AbiCOHhe (ORCPT + 99 others); Tue, 15 Mar 2022 03:37:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345441AbiCOHhe (ORCPT ); Tue, 15 Mar 2022 03:37:34 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F9264B402 for ; Tue, 15 Mar 2022 00:36:21 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2e5757b57caso35565407b3.4 for ; Tue, 15 Mar 2022 00:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Uj1acuBG5kcEqw59Y4tqrJax7+x9T6dt2CoxNkY2Fak=; b=moVlMSHF69zGnMI/0PjKcxJsN+D1KS9lGLTiZtmLi/MyLQssQUI+L/Qt+5gaUew6D1 GVRFrWCk7PXO9aB7Od6Kr++gUz5iNM9Izij517YOstugCCL+YBngkx+2NprBdfVsEYN4 gpVBiU1SV3+84iXltCUfVi33UElnavUetxwZGn5+bHSQ4jGXyUvRPjPqoo/r3H9mkXev BcvcIY9bymdJcMKSa/f788r3jfXwqvW69K8PSdwDAD9bNsI02vXSvm2OLj5WzCSTC4gh G8Wvjkamm3vPUK26yrbPqQ47QBmro1gcJQkOExaJJgnHM65tMSZmPLTpIPBPEBXXzNVV 6H4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Uj1acuBG5kcEqw59Y4tqrJax7+x9T6dt2CoxNkY2Fak=; b=13xj47ALuVPFQCdkw7+Hgc7EKmO5IZesVJuzo2zRL5DngMuccxWbHhqUE12inyXgpG 6yFsIqbrboVd+Wb10z6EtgoKEFrQCxhBUkQqD+ONiZdmIez6oO3YTC3nR1YiT8VF1pxT CwaPXBRW29YfYHepLF0THGc2y/o4uYPO7NsdWi4aEVG4WZey8vw2j9M6CRfsU2G4Z2Vr 67s1GmGWTpMgUAOY1JKGaqURJub3X/qv47BE9yq+pgTYTsf77nXEosAv/iLpMZNRsey2 ejrz+6T8vrPrNMQuh5RoCE4d9ZJA8piZRQzdOsR3P3lAs/AaFLlqb9LLv1e7dwQRgc8V CZvw== X-Gm-Message-State: AOAM530MJ90eKWEOa/uMJbZIcEpjDvzPFv6fKuwzGk7NJFo6ms3YAOn2 lexDGwYf4Vp4xQATAxUvWUJ3Rw/iDtDB/0vfhbA= X-Received: by 2002:a81:1601:0:b0:2dc:149d:b302 with SMTP id 1-20020a811601000000b002dc149db302mr11928835yww.203.1647329780670; Tue, 15 Mar 2022 00:36:20 -0700 (PDT) MIME-Version: 1.0 References: <20220308092047.1008409-1-butterflyhuangxx@gmail.com> In-Reply-To: From: butt3rflyh4ck Date: Tue, 15 Mar 2022 15:36:11 +0800 Message-ID: Subject: Re: [PATCH] virt: acrn: fix a memory leak in acrn_dev_ioctl() To: Greg KH Cc: Li Fei1 , LKML Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok, thanks. By the way, I want to explain, Firstly there is just some parameter that should be freed before func returns the -EINVAL error in the patch. I think it was correct, no need to test it. And secondly the commitor Li Fei1 also reviewed the patch code. finally I am sorry that no arcn hso hardware to test it. Regards, butt3rflyh4ck. On Tue, Mar 15, 2022 at 2:49 PM Greg KH wrote: > > On Tue, Mar 15, 2022 at 10:44:09AM +0800, butt3rflyh4ck wrote: > > Hi, Greg, could you tell me how to test (like this)? > > I have no context at all what "like this" is sorry. > > greg k-h -- Active Defense Lab of Venustech