Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220315103813.84407-1-shreeya.patel@collabora.com> <202203160100.PENzQsMs-lkp@intel.com>
In-Reply-To: <202203160100.PENzQsMs-lkp@intel.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 15 Mar 2022 20:05:20 +0200
Message-ID: <CAHp75Vcsxn+8H-tpkN_ipjW4XGsfnhd7NA5Rz+cvGt7T4C9xfQ@mail.gmail.com>
Subject: Re: [PATCH v2] gpio: Restrict usage of gc irq members before initialization
To:     kernel test robot <lkp@intel.com>
Cc:     Shreeya Patel <shreeya.patel@collabora.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, krisman@collabora.com,
        kbuild-all@lists.01.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 15, 2022 at 7:38 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Shreeya,
>
> Thank you for the patch! Yet something to improve:


> All errors (new ones prefixed by >>):
>
>    drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:29: error: 'struct gpio_chip' has no member named 'irq'
>     3068 |         if (gc->to_irq && gc->irq.gc_irq_initialized) {
>          |                             ^~

Exactly, because this check should go under ifdeffery.

-- 
With Best Regards,
Andy Shevchenko