Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e888d777-71f8-8ddc-7590-53e181ae0ad4@pengutronix.de>
Date:   Wed, 16 Mar 2022 12:17:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [Linux-stm32] [PATCH v2 12/13] ARM: dts: stm32: enable optee
 firmware and SCMI support on STM32MP13
Content-Language: en-US
To:     Etienne Carriere <etienne.carriere@linaro.org>,
        Gabriel FERNANDEZ <gabriel.fernandez@foss.st.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-stm32@st-md-mailman.stormreply.com,
        Pengutronix Kernel Team <kernel@pengutronix.de>
References: <CAN5uoS9F1cjN+WLks1S=GzA1SHw=o-ibFbu-VsUzJ4NydAkAdw@mail.gmail.com>
From:   Ahmad Fatoum <a.fatoum@pengutronix.de>
In-Reply-To: <CAN5uoS9F1cjN+WLks1S=GzA1SHw=o-ibFbu-VsUzJ4NydAkAdw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Etienne,

On 16.03.22 12:01, Etienne Carriere wrote:
> Hi Ahmad,
> 
>> Helo Gabriel,
>>
>> On 03.03.22 14:09, Gabriel FERNANDEZ wrote:
>>>
>>> On 2/25/22 16:13, Ahmad Fatoum wrote:
>>>> Hello Gabriel,
>>>>
>>>> On 25.02.22 14:31, gabriel.fernandez@foss.st.com wrote:
>>>>> From: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>>>>> +    firmware {
>>>>> +        optee {
>>>>> +            method = "smc";
>>>>> +            compatible = "linaro,optee-tz";
>>>>> +        };
>>>>> +
>>>>> +        scmi: scmi {
>>>>> +            compatible = "linaro,scmi-optee";
>>>> This compatible doesn't seem to be documented upstream. I am looking at v5.17-rc5.
>>>> Do you have a reference detailing the difference between this conduit and
>>>> plain arm,scmi-smc (as used with TF-A on the STM32MP151).
>>>>
>>>> Cheers,
>>>> Ahmad
>>>
>>> Hi
>>>
>>> Ahmad,
>>>
>>> it's on going.
>>>
>>> https://lore.kernel.org/linux-arm-kernel/20211029102118.GG6526@e120937-lin/T/#mf46c83f0aadce3061ee93fa22159405f38d881a0
>>
>> I've found that thread in the meantime and got some clarification on why a new
>> transport for OP-TEE was added. One question I still have though is why make
>> this transport the default for STM32MP13x instead of using SCMI over SMC like
>> you do for STM32MP15x. OP-TEE could still be made to service SCMI over SMC
>> and it would allow people employing TF-A as SCMI provider an easier migration
>> to the newer SoC.
>>
> 
> Just to rephrase a bit what's being said in the referred mail thread:
> On STM32MP13x, there are SCMI messages that must be processed inside a
> thread execution context in the SCMI server. There is no standard SMC
> function ID defined that the SCMI/SMC transport could use for that
> purpose. OP-TEE provides such a threaded context. Therefore STM32MP13x
> explicitly expects SCMI services based on SCMI/OP-TEE transport, not
> SCMI/SMC transport.

I see. Users can still override it as they see fit and I understand that
ST would prefer to have the "fully-featured" boot chain be the default
for the new SoC. So no concerns from my side.

Thanks a lot for the clarification!

Cheers,
Ahmad

> 
> Best regards,
> etienne
> 
>> Cheers,
>> Ahmad
> 
>>
>>>
>>>> +            #address-cells = <1>;
>>>> +            #size-cells = <0>;
>>>> +            linaro,optee-channel-id = <0>;
>>>> +            shmem = <&scmi_shm>;
>>>> +
>>>> +            scmi_clk: protocol@14 {
>>>> +                reg = <0x14>;
>>>> +                #clock-cells = <1>;
>>>> +            };
>>>> +
>>>> +            scmi_reset: protocol@16 {
>>>> +                reg = <0x16>;
>>>> +                #reset-cells = <1>;
>>>> +            };
>>>> +        };
>>>> +    };
>>>>       clocks {
>>>>           clk_axi: clk-axi {
>>>>               #clock-cells = <0>;
>>>
>>
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |