Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Lu=C3=ADs_Henriques?= <lhenriques@suse.de>
To:     Xiubo Li <xiubli@redhat.com>
Cc:     Jeff Layton <jlayton@kernel.org>,
        Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] ceph: add support for encrypted snapshot names
References: <20220310172616.16212-1-lhenriques@suse.de>
        <20220310172616.16212-2-lhenriques@suse.de>
        <fdf774cd-3cca-14e5-d5aa-44de70bb89f0@redhat.com>
        <2d69e6dd-b047-13fe-7dc5-2c64190e0e8a@redhat.com>
        <cff2b7ac-d4bb-4096-06a9-79b41b31a57a@redhat.com>
        <87o8288jwd.fsf@brahms.olymp>
        <7aedb4b9-11e4-cfa1-986f-75cf8706c6c0@redhat.com>
Date:   Tue, 15 Mar 2022 11:05:43 +0000
In-Reply-To: <7aedb4b9-11e4-cfa1-986f-75cf8706c6c0@redhat.com> (Xiubo Li's
        message of "Tue, 15 Mar 2022 15:28:48 +0800")
Message-ID: <87ee33jx14.fsf@brahms.olymp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Xiubo Li <xiubli@redhat.com> writes:
<...>
> I think there has one simple way. Just think about without setting the
> fscrypt_auth for the '.snap' dir's inode, that is without your this=20
> patch it works well.
>
> That's because when we create a snapshot under '.snap' dir, since the '.s=
nap'
> dir related inode doesn't have the fscrypt_auth been filled, so when crea=
ting a
> new inode for the snapshot it won't fill the fscrypt_auth for the new ino=
de. And
> then in the handle_reply() it can fill the fscrypt auth as expected.
>
> You can make sure that in the ceph_new_inode() just skip setting the
> fscrypt_auth for the new inode if the parent dir is a snapdir, that is=20
> '.snap/'. And this will just leave it to be filled in the handle_reply().

Ah! That's it!  Great suggestion, I'll go test this and send out a new
version later.  (And I think I'll need to rebase my patches on top of the
latest changes too.)

Cheers,
--=20
Lu=C3=ADs