Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        netdev@vger.kernel.org (open list:NETWORKING [GENERAL]),
        linux-kselftest@vger.kernel.org (open list:KERNEL SELFTEST FRAMEWORK),
        linux-kernel@vger.kernel.org (open list)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] selftests: net: fix warning when compiling selftest/net
Date:   Wed, 16 Mar 2022 19:50:40 +0800
Message-Id: <20220316115040.10876-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7zVBlQvE3Mks9Sp7jddl4/mmW1jTv4X0/vgCp6aqGpB2d1PEwmzqc9OQ3tl?=
 =?us-ascii?Q?lAxQOYcpqb/kzmVhwEWW0ZwIznNK/tqGKvbQPQ3SYVkYqluWRcy6xIlS0cIL?=
 =?us-ascii?Q?46djxL0fHqI0VUwTcjcZqdyguTh48kLPHcmNIefiDpDBoaI8aeOoww/AqkpB?=
 =?us-ascii?Q?z3jhNL2wM4CrjdmCMdNhSKIJLEePY1mjNJNa2clV6IiL2igCUx0bnUvoIFg0?=
 =?us-ascii?Q?oOhQkWTdgjVjcQ7pqjkw60vTdphfuqqUB4Vz5cQjD8QCuOtl0mLphytQe6Mr?=
 =?us-ascii?Q?4F4+E3q0sVN6/F38KyIPvOs1MCiKFOShXx8ndyQmuRUa+VA0YY0L+PGenjvF?=
 =?us-ascii?Q?DtPLJyS7f0jkPDBIAy0eMPo4O43irieE5dtvmsHynpQ/FdjPJqQTq4SNMK+u?=
 =?us-ascii?Q?B7ZkaiRLtzdyXRYYTMbG1cNmKACbZ3WFMy2XbmK13HzadZXSBtGZOxgWgiQ4?=
 =?us-ascii?Q?sXonBqrx9TD1VwRfyqpIVDUfUrVH6V5nYCPTDt7VWwFw7lWoGKJqUNZzwV62?=
 =?us-ascii?Q?Vp+lADM+X8lW5//qfPWinoXncAlr/S9Nfox9wo1rReRAe+xpmgk3eNWrpYd9?=
 =?us-ascii?Q?un1Z05/CUTb4i7K75jtvRIHyJR0aiMhSF+cpgCI8zKxJGSjMuZSObDgC2ZO8?=
 =?us-ascii?Q?swCqi1LTiZv/HjeBMha8kZHIuUdCX829MpsHveHyAfcsrYbIs6HGrp0T1zFa?=
 =?us-ascii?Q?SO8BV2HkZNXe6Ls57fb0jLhLe0y2Si3+lCexrKC9TjHXG7tn8sCsJpZESw0j?=
 =?us-ascii?Q?38LcuT0i06RbCvljx351L7TIg+RqZRA+oJs86Y44FoYvkwTT7fZn6NB0HZKt?=
 =?us-ascii?Q?i0w2p7WWJ6+hrKHqPnp7Pb/4s5Xxsd/N5DqXQDopj8ECeV4uDYkJyw7Xd4Ky?=
 =?us-ascii?Q?6ZPTIaQxjzCU+EVfwMxxkM7H5dSCbTYRA/WbyYBpFPFV40knZLN5KJvU9saw?=
 =?us-ascii?Q?jjb/sNzo74Qb0T8gkT5rno2mVnUDDxC3fD8XfRx2PsgpfV+VnUcFWloDeDh/?=
 =?us-ascii?Q?QpTCnmpZOPUJd4izjItdgzZdzoUP4ufrfURbFq2S0Vpcf3Zqc3C9PHNets8I?=
 =?us-ascii?Q?iYIPPZ8c55ckpszMwoCasNDAnBdHuQw7fReEvbtLh7FOe+y8kP/aU5JxImZ1?=
 =?us-ascii?Q?PnU7m0CSX0/VsVczQYHjn0nhIHHSfzGYOjWp775E0qSfqJAkT40IPSfxVLCX?=
 =?us-ascii?Q?HaNTaLpWAFkZK56/ivfv8X1mEVtuzG0pJlUa8eohRL4Wclks/L8KzyMqx8GS?=
 =?us-ascii?Q?bb4RsCW+Cmvladk2uGZVz/+GH3CZl8wAY90OOX8qAY1cT54GEBs4wHGmmK/T?=
 =?us-ascii?Q?lS6ovea9D8OkTZ4SnQLgNP5md+Ib7+y8lJs/FURnPTxnpvnYgT8/oBP4ZXo7?=
 =?us-ascii?Q?OlEgm11YH/ZeQZaAjyuhSBRs8MvqiLTCfaO+oM1y0MLzSSJaZKwAMSrqWkMU?=
 =?us-ascii?Q?geHnrerkKmOQ7ikdhWs3P4IlETpf9BQV?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63fb3f39-4d1b-4206-2e3d-08da07433a03
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2022 11:50:54.5242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JUdgfkhdDGomhi62PnIVtzWczGjQePc3yzaKRz6AJZjhGhh6JdF0McxXTJACsGL8SHIaBP97ohEOYbAQUMP4Yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB2888
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When I compile tools/testing/selftests/net/ by
`make -C tools/testing/selftests/net` with gcc (Debian 8.3.0-6) 8.3.0,
it reports the following warnings:

txtimestamp.c: In function 'validate_timestamp':
txtimestamp.c:164:29: warning: format '%lu' expects argument of type
'long unsigned int', but argument 3 has type 'int64_t'
{aka 'long long int'} [-Wformat=]
   fprintf(stderr, "ERROR: %lu us expected between %d and %d\n",
                           ~~^
                           %llu
     cur64 - start64, min_delay, max_delay);
     ~~~~~~~~~~~~~~~
txtimestamp.c: In function '__print_ts_delta_formatted':
txtimestamp.c:173:22: warning: format '%lu' expects argument of type
'long unsigned int', but argument 3 has type 'int64_t'
{aka 'long long int'} [-Wformat=]
   fprintf(stderr, "%lu ns", ts_delta);
                    ~~^      ~~~~~~~~
                    %llu
txtimestamp.c:175:22: warning: format '%lu' expects argument of type
'long unsigned int', but argument 3 has type 'int64_t'
{aka 'long long int'} [-Wformat=]
   fprintf(stderr, "%lu us", ts_delta / NSEC_PER_USEC);
                    ~~^
                    %llu

`int64_t` is the alias for `long long int`. '%lld' is more suitable.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 tools/testing/selftests/net/txtimestamp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c
index fabb1d555ee5..ab8d0181218f 100644
--- a/tools/testing/selftests/net/txtimestamp.c
+++ b/tools/testing/selftests/net/txtimestamp.c
@@ -161,7 +161,7 @@ static void validate_timestamp(struct timespec *cur, int min_delay)
 	max_delay = min_delay + cfg_delay_tolerance_usec;
 
 	if (cur64 < start64 + min_delay || cur64 > start64 + max_delay) {
-		fprintf(stderr, "ERROR: %lu us expected between %d and %d\n",
+		fprintf(stderr, "ERROR: %lld us expected between %d and %d\n",
 				cur64 - start64, min_delay, max_delay);
 		test_failed = true;
 	}
@@ -170,9 +170,9 @@ static void validate_timestamp(struct timespec *cur, int min_delay)
 static void __print_ts_delta_formatted(int64_t ts_delta)
 {
 	if (cfg_print_nsec)
-		fprintf(stderr, "%lu ns", ts_delta);
+		fprintf(stderr, "%lld ns", ts_delta);
 	else
-		fprintf(stderr, "%lu us", ts_delta / NSEC_PER_USEC);
+		fprintf(stderr, "%lld us", ts_delta / NSEC_PER_USEC);
 }
 
 static void __print_timestamp(const char *name, struct timespec *cur,
-- 
2.20.1