Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp869986pxp; Wed, 16 Mar 2022 19:39:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHA9bEU5gNB04PZAEEnTMcRTQh8XeOtfBlueRabKgpkF3nGois0wRGl850wK42G22Izh/i X-Received: by 2002:a17:90b:4f4e:b0:1bf:b4e5:f4c0 with SMTP id pj14-20020a17090b4f4e00b001bfb4e5f4c0mr2838250pjb.129.1647484782038; Wed, 16 Mar 2022 19:39:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647484782; cv=none; d=google.com; s=arc-20160816; b=j1g9T5KVqhRk3/aOFT64a0RgCCJ1kipx8syM3l4TeM748bgK/jLt4Uxe8EE5VTsPYQ oQM2CAINGvsBGr6VuPtz7AYUKFV5R1AGeqshjcQD4lCo+VuwpnHRLtJCg/KUDY3i4wZG jIN/uHWqX49BLDG61mzT5WtCNWso/LEvqqX4xV9GjOULtYc+nWU8NSvjYYKNpK9urTGA gHVMPaJygb2VvnHEv+JUx89xUSrqs/3GxhSSm5E7oG17nUHqf7ilEuzo9jJYlgF7ZcS8 ++Q5onwgLas1XLTK5V0JD5MHX7w4TOtsKIyUivlbA2ong+lqxht2DfSnc0iXx0DTOvgz ui1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DUykiP8nfjBdfUw7UmZqhWGy1tg94qgmfTWnuFxc8mI=; b=05YrhDwtADQSHAA+5hb0QFVfq2Ru9YGvi7Y4btaelV/mru8FHooWdfuJxmBTUBk5p1 udtU0lp0FtHXkUQq/Vn/KPTDbkEZW+pNuNzSgpo5XVsMren1nQH9Fndwy1DyHKvKxrWx KIsq4HRI26LtJFQYfbFCUcW2Naqfg1Gukb3pzl17KipQRsFhy9DHfiyhnrWo1nwhGGnu 2yhQDCYU0O6StlqqV0G61txOj3f4Myr0iSE4VefFs6m0S+dpvw1zIPgtubS2I9rqE7HF Q4XYV9ItN3gAAjgsC4iCh4doWnQthNUjD4oWvU0hzkoadOPDJ5zFUVrzpk73n0Uhv8WY GMjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hcYgoEL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a630d01000000b003816043ef9fsi859696pgl.404.2022.03.16.19.39.28; Wed, 16 Mar 2022 19:39:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hcYgoEL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240246AbiCNMCl (ORCPT + 99 others); Mon, 14 Mar 2022 08:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240245AbiCNMCX (ORCPT ); Mon, 14 Mar 2022 08:02:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67B5C488A3; Mon, 14 Mar 2022 04:59:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB42FB80D24; Mon, 14 Mar 2022 11:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41AA6C340E9; Mon, 14 Mar 2022 11:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647259184; bh=zWVrTmPSziRDlOkzvchLv5PD3fJkMV+hctHczVrVRVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hcYgoEL3BSf2wuyTDvujNu0R/LXkkULlUPSU2GfXNnL7ebHmEmcUZAvLQtqrBmH9T WojknSdZt9M2qVnN0/0tFVXP7yuVjAXPY6J60Vzh5vh0UUYgrGZn/7mrsODlctAJA+ EeseQ4knS3wzbq1YLA2jyHa8xt3sw84dizateMrQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Grzegorz Siwik , Jedrzej Jagielski , Tony Nguyen , Sasha Levin , Gurucharan Subject: [PATCH 5.10 21/71] ice: Fix curr_link_speed advertised speed Date: Mon, 14 Mar 2022 12:53:14 +0100 Message-Id: <20220314112738.525866564@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220314112737.929694832@linuxfoundation.org> References: <20220314112737.929694832@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jedrzej Jagielski [ Upstream commit ad35ffa252af67d4cc7c744b9377a2b577748e3f ] Change curr_link_speed advertised speed, due to link_info.link_speed is not equal phy.curr_user_speed_req. Without this patch it is impossible to set advertised speed to same as link_speed. Testing Hints: Try to set advertised speed to 25G only with 25G default link (use ethtool -s 0x80000000) Fixes: 48cb27f2fd18 ("ice: Implement handlers for ethtool PHY/link operations") Signed-off-by: Grzegorz Siwik Signed-off-by: Jedrzej Jagielski Tested-by: Gurucharan (A Contingent worker at Intel) Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c index 0582fca5e07f..421fc707f80a 100644 --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c @@ -2299,7 +2299,7 @@ ice_set_link_ksettings(struct net_device *netdev, goto done; } - curr_link_speed = pi->phy.link_info.link_speed; + curr_link_speed = pi->phy.curr_user_speed_req; adv_link_speed = ice_ksettings_find_adv_link_speed(ks); /* If speed didn't get set, set it to what it currently is. -- 2.34.1