Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Subject: Re: [PATCH v3] livepatch: Don't block removal of patches that are
 safe to unload
To:     Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>
Cc:     Chengming Zhou <zhouchengming@bytedance.com>, jpoimboe@redhat.com,
        jikos@kernel.org, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
        qirui.001@bytedance.com
References: <20220312152220.88127-1-zhouchengming@bytedance.com>
 <alpine.LSU.2.21.2203161536330.6444@pobox.suse.cz> <YjH7rniD4rBO6JIP@alley>
 <alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz>
From:   Joe Lawrence <joe.lawrence@redhat.com>
Message-ID: <6c613fc8-a436-a17e-799f-afd2ead02bb5@redhat.com>
Date:   Wed, 16 Mar 2022 21:43:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/16/22 11:03 AM, Miroslav Benes wrote:
>>>> + /*
>>>> +	 * Only need to set forced flag for the transition patch
>>>> +	 * when force transition to KLP_UNPATCHED state, but
>>>> +	 * have to set forced flag for all replaced patches
>>>> +	 * when force atomic replace transition.
>>>> +	 */
>>>
>>> How about something like
>>>
>>> /*
>>>  * Set forced flag for patches being removed, which is the transition
>>>  * patch in KLP_UNPATCHED state or all replaced patches when forcing
>>>  * the atomic replace transition.
>>>  */
>>
>> Or just the first sentence:
>>
>> 	/* Set forced flag for patches being removed */
>>
>> The rest is visible from the code.
> 
> True. This would work for me as well.
> 

Sorry for not following this one more closely as we don't use force nor
atomic replace patches (yet) ... but the code and use case seems clear
enough for the shorter comment.

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- 
Joe