Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbXBVVzJ (ORCPT ); Thu, 22 Feb 2007 16:55:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751965AbXBVVzJ (ORCPT ); Thu, 22 Feb 2007 16:55:09 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:52807 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbXBVVzH (ORCPT ); Thu, 22 Feb 2007 16:55:07 -0500 Date: Thu, 22 Feb 2007 21:55:01 +0000 From: Christoph Hellwig To: James Bottomley Cc: "Mike Miller (OS Dev)" , akpm@osdl.org, jens.axboe@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, gregkh@novell.com, hch@infradead.org Subject: Re: [Patch 2/2] cciss: add shutdown support (replaces reboot notifier) Message-ID: <20070222215501.GA21037@infradead.org> Mail-Followup-To: Christoph Hellwig , James Bottomley , "Mike Miller (OS Dev)" , akpm@osdl.org, jens.axboe@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, gregkh@novell.com References: <20070222213845.GA14162@beardog.cca.cpqcorp.net> <1172180978.3378.35.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1172180978.3378.35.camel@mulgrave.il.steeleye.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 17 On Thu, Feb 22, 2007 at 03:49:38PM -0600, James Bottomley wrote: > On Thu, 2007-02-22 at 15:38 -0600, Mike Miller (OS Dev) wrote: > > .remove = __devexit_p(cciss_remove_one), > > .id_table = cciss_pci_device_id, /* id_table */ > > + .shutdown = cciss_remove_one, > > You need a __devexit_p() wrapper for this one too. No. We want to call this even in the non-modular, non-hotplug case. So we should remove __devexit from cciss_remove_one. Or alternatively implement a separate cciss_shutdown that just does the nessecary cache flushing, like most other drivers do. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/