Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp900768pxp; Wed, 16 Mar 2022 20:39:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcNEDU0tHmQyyqFMXTbnwWC3Inks/EAUlpf06Ce13ZmkRjp0PXfeTPcyKZH4vsDHHOmu44 X-Received: by 2002:a17:90b:1652:b0:1bf:32e9:6db3 with SMTP id il18-20020a17090b165200b001bf32e96db3mr3051735pjb.179.1647488380970; Wed, 16 Mar 2022 20:39:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647488380; cv=none; d=google.com; s=arc-20160816; b=VEDRq2RSUV7UmmZsN62XwPKElZWffb2sQ/Y0CFV2zYaRX3Fu8YC5Yg0xjTCUQjr5aP OD0GrgdVF0OoJA+5JJy6O4ikQn8cKEgNJHqM0WY8UMJti681qLarsYlnKGcMDAKqq1A7 m7Qvkt1D5D3Rx7o91z9q+1XE0xIkFg2jBfztWmAYM80Bz24SU1ksejNm4Zw1iwIEUO98 iFcL902uDjbQ14fVZN23ku6Ljc4zwcauHxVGkmCubrjzQuKrQUNlxjRVbzvR5aymOucn jNt9WN8x9vJzp8GLTrl1irwMm22XueI2cN8k9CYSeijO+gMskJ3PfRgksEXLHRxvNbjL L4fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=tlN6D0oUs0HDWeSF4UZed1bY7XhynT3ZRWZVA3EAXaw=; b=lSDNjHtZm2+aHIUSdZzk80nQ+RhiBpObeNGyZvkoC/WWpGD7KaXOrFrtR8fvggdz8S OmpN5IVqSLRXDA9snK5lDCXYrHak6gLIri1xUAfkKEqvtgic81eICBPZHGFEsIu4DWNs 6jzu1Dx07XH95hC2iNSTHo3D7HDPScpjZWeD5Xq2kmYeFJO/Sb8WY2X1OO2oN3RdmQAa 9kb9jaDIJbQe2N/fVdcWdpJUgCS4l5BjzgUn1EXLImhFaWSP0YHWHrxgLTH7DexKoVyN 8xpiEzJWTYQ1xjHSgiZAI+ls13b1fFQ6DUxuqnWgEi8tzj+1cE8QA/p40vZsLtxLbcCS zhBg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id o15-20020a656a4f000000b0038206e0017esi609453pgu.558.2022.03.16.20.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 20:39:40 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CBE462E09A; Wed, 16 Mar 2022 20:33:11 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357409AbiCPP5C (ORCPT + 99 others); Wed, 16 Mar 2022 11:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343799AbiCPP47 (ORCPT ); Wed, 16 Mar 2022 11:56:59 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A341F5F4F0; Wed, 16 Mar 2022 08:55:45 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66AC91476; Wed, 16 Mar 2022 08:55:45 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89E853F7D7; Wed, 16 Mar 2022 08:55:43 -0700 (PDT) Date: Wed, 16 Mar 2022 15:55:41 +0000 From: Sudeep Holla To: Darren Hart , Will Deacon , Greg Kroah-Hartman Cc: Dietmar Eggemann , Vincent Guittot , LKML , Linux Arm , "Rafael J. Wysocki" , Catalin Marinas , Peter Zijlstra , Valentin Schneider , "D . Scott Phillips" , Ilkka Koskinen , stable@vger.kernel.org, Barry Song <21cnbao@gmail.com> Subject: Re: [PATCH v3] topology: make core_mask include at least cluster_siblings Message-ID: References: <20220308103012.GA31267@willie-the-truck> <7ac47c67-0b5e-5caa-20bb-a0100a0cb78f@arm.com> <9398d7ad-30e7-890a-3e18-c3011c383585@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2022 at 08:20:32AM -0700, Darren Hart wrote: > On Wed, Mar 16, 2022 at 03:48:50PM +0100, Dietmar Eggemann wrote: [...] > > > > Yeah, I can see your point. It's the smaller hack. My solution just > > prevents us to manipulate the coregroup mask only to get the MC layer > > degenerated by the core topology code. But people might say that's a > > clever thing to do here. So I'm fine with your original solution as well. > > > > [...] > > Thanks Dietmar, > > Sudeep, do we have sufficient consensus to pull in this patch? Indeed. I have already Acked, and sure after all these discussions we have concluded that this is the best we can do though not matches everyone's taste. Greg or Will(not sure why he had asked since v3 doesn't touch arm64), Can one of you pick this patch ? -- Regards, Sudeep