Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp901849pxp; Wed, 16 Mar 2022 20:41:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwgXlG3Zkq7hYC3fsXqyFsQ5Jy5mc9ovYtzHgCzEP4SL6/+D8cabXi0HPhZ1/GI4eHDSNF X-Received: by 2002:a05:6a00:148b:b0:4f8:20de:3dd1 with SMTP id v11-20020a056a00148b00b004f820de3dd1mr2669293pfu.70.1647488508066; Wed, 16 Mar 2022 20:41:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647488508; cv=none; d=google.com; s=arc-20160816; b=g6DIP0GVafavTpX9ZuWsQypCHqze99r3RguuuiwL27UWijUyZLUYmU0Hh4OIAZis20 6X05pU3GIxR4ovUg6dvE9YqDw9s9HaJBH/ahDtZWQJpCDc3MvnM7dr5V8uBHFDZSn9+3 kmvl+IpCSaG9z1EjgmG5BxgDcS+5WwmU/ZmEq7Bz9DjJcxI9EN9UL+2PQb/lMPXNdQwG RS6utNW37roo29TaFzVaVOmh6OUv2kDLrauLevxmIqP9KXCBiSAlbEXlN0T9Wi3I3F8o FFF4C5phPhjniDoGj1SMfYrlkzUTaT60+MqiSGF5DgxPogQ4GwWmzVFgOQOFPzR8spAq oKZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=94fOI1XcQDRPiq93H6jmTA5y7uwXpAEzag4+dn7CXIE=; b=u357GaqH7skjpbD1bGZabJ5014WqL8MtlLMcAChAE75WlDh1V0NCPi4unA4B2B8B5r bW3ao8SrMMG47NnEWOSHr7yJ8/UMGJ5KEou2QURCNz4MRjuDDtQrkI2UOIMuZRw2kpcs oQNSRZsWHNuHOAqpnxb/wmj4e24wRIkhRtS7tEThHS2u9qq1tr0qEP7QjZQAVH+IHb/6 fD9g4utUCAfj6q6YpPCoHCmB8s9ZV+ajP7mH+5bK2brumphMc0do9Zxbo4BAlMmhga/m 3MZ1i8VWd1l5mjVKB/qdmQJ+5G3ncXfnblTRDsSrZOAw4zT/65N3/CPQCLYQdOO+Vnp9 V7Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bEzzIzE+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z3-20020a170903408300b00151d8a50ff0si2990127plc.535.2022.03.16.20.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 20:41:48 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bEzzIzE+; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0EA3462A1A; Wed, 16 Mar 2022 20:34:35 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245136AbiCORng (ORCPT + 99 others); Tue, 15 Mar 2022 13:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239523AbiCORnf (ORCPT ); Tue, 15 Mar 2022 13:43:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A58B58E4F; Tue, 15 Mar 2022 10:42:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD2BF615DB; Tue, 15 Mar 2022 17:42:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26E43C340E8; Tue, 15 Mar 2022 17:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647366142; bh=fthfjXVt7Bp2FFoEC8d2OpN/NXHxJduJSdvt+y0+wXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bEzzIzE+NrrLwhy5BBYLT0Hg1DhsFdqRLwndEFnoLsA/MKLw1Oyo0IT0QWruQnA9g 7r2gkSXCGSr6J6lc5EareWuiUIPHDKPSwLfDwUCB4vSG1weAwCt4ZjDGiPe0AhsqW5 UU7DZQTEEAyDAh4YTHMPRvOTsu1ayD14lTk5BJaU= Date: Tue, 15 Mar 2022 18:42:14 +0100 From: Greg KH To: Andrey Smirnov Cc: Felipe Balbi , Thinh Nguyen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Thinh Nguyen Subject: Re: [PATCH v3] usb: dwc3: Don't switch OTG -> peripheral if extcon is present Message-ID: References: <20220228171252.1827788-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220228171252.1827788-1-andrew.smirnov@gmail.com> X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 09:12:52AM -0800, Andrey Smirnov wrote: > If the extcon device exists, get the mode from the extcon device. If > the controller is DRD and the driver is unable to determine the mode, > only then default the dr_mode to USB_DR_MODE_PERIPHERAL. > > Cc: Felipe Balbi > Cc: Thinh Nguyen > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Reviewed-by: Thinh Nguyen > Signed-off-by: Andrey Smirnov > --- > > Changes since [v2] of the patch: > > - Fixed "Minor formatting change", to reflect what was meant by > review comment > > Changes since [v1] of the patch: > > - Reworded commit message > - Minor formatting change Does not apply to my tree :(